Bug 54641

Summary: [Qt] ImageDiff sometimes hangs
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: ariya.hidayat, cmarcelo, commit-queue, hausmann, kling
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
proposed fix none

Csaba Osztrogonác
Reported 2011-02-17 05:39:59 PST
On r78808 it is easily reproducable: (Using platform mac to get many pixel differences) $ Tools/Scripts/run-webkit-tests --debug --platform mac -p svg/W3C-SVG-1.1-SE/coords-dom-01-f.svg svg/W3C-SVG-1.1-SE/coords-dom-02-f.svg svg/W3C-SVG-1.1-SE/coords-dom-03-f.svg svg/W3C-SVG-1.1-SE/coords-dom-04-f.svg svg/W3C-SVG-1.1-SE/filters-image-03-f.svg svg/W3C-SVG-1.1-SE/paths-dom-02-f.svg During the 5. test ImageDiff hangs: Tools/DumpRenderTree/qt/ImageDiff.cpp:138: if (fwrite(data.constData(), 1, data.length(), stdout)) {} I'm going to debug and fix this bug. It is the first step to run Qt pixel tests. ;)
Attachments
proposed fix (978 bytes, patch)
2011-02-17 08:47 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2011-02-17 08:47:11 PST
Created attachment 82816 [details] proposed fix
Csaba Osztrogonác
Comment 2 2011-02-17 08:57:43 PST
ImageDiff was written by Ariya and reviewed by Simon: https://bugs.webkit.org/show_bug.cgi?id=27813 ImageDiff is able to compare pairs of images. actualImage and baselineImage should be cleared after all comparison: + actualImage = QImage(); + baselineImage = QImage();
Andreas Kling
Comment 3 2011-02-17 08:59:08 PST
Comment on attachment 82816 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=82816&action=review > Tools/DumpRenderTree/qt/ImageDiff.cpp:146 > + actualImage = QImage(); > + baselineImage = QImage(); This should be below the next } so they get cleared if one of them isNull(), too.
Andreas Kling
Comment 4 2011-02-17 09:03:36 PST
Comment on attachment 82816 [details] proposed fix Superficial review fail, didn't realize this was an FSM. r=me, motherlover :)
WebKit Commit Bot
Comment 5 2011-02-17 09:40:04 PST
The commit-queue encountered the following flaky tests while processing attachment 82816 [details]: media/invalid-media-url-crash.html bug 51138 (author: inferno@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2011-02-17 09:41:47 PST
Comment on attachment 82816 [details] proposed fix Clearing flags on attachment: 82816 Committed r78840: <http://trac.webkit.org/changeset/78840>
WebKit Commit Bot
Comment 7 2011-02-17 09:41:52 PST
All reviewed patches have been landed. Closing bug.
Caio Marcelo de Oliveira Filho
Comment 8 2011-03-28 06:39:23 PDT
Revision r78840 cherry-picked into qtwebkit-2.1 with commit 3d8aeee68ff7943cc50e4b321b1071195b671d0a <http://gitorious.org/webkit/qtwebkit/commit/3d8aeee68ff7943cc50e4b321b1071195b671d0a>
Caio Marcelo de Oliveira Filho
Comment 9 2011-03-28 06:43:54 PDT
Also merged into qtwebkit-2.1.x
Note You need to log in before you can comment on or make changes to this bug.