Bug 54833

Summary: Remove pthread dependency of GCController
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: WebCore JavaScriptAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, aroben, commit-queue, eric, ggaren
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Patrick R. Gansterer
Reported 2011-02-20 13:39:19 PST
Remove pthread dependency of GCController
Attachments
Patch (1.59 KB, patch)
2011-02-20 13:40 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (1.62 KB, patch)
2011-02-22 12:30 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (1.67 KB, patch)
2011-02-22 12:42 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2011-02-20 13:40:53 PST
Created attachment 83102 [details] Patch
Alexey Proskuryakov
Comment 2 2011-02-20 17:18:49 PST
The patch looks fine to me, but the code as a whole doesn't. Shouldn't we call pthread_detach() in immediate return case? CC'ing the author of this code in case I'm somehow confused.
Geoffrey Garen
Comment 3 2011-02-21 12:16:22 PST
(In reply to comment #2) > Shouldn't we call pthread_detach() in immediate return case? Yes. This is a bug.
Patrick R. Gansterer
Comment 4 2011-02-21 12:18:46 PST
Comment on attachment 83102 [details] Patch (In reply to comment #3) > (In reply to comment #2) > > Shouldn't we call pthread_detach() in immediate return case? > > Yes. This is a bug. I'll create a new patch in the next days.
Patrick R. Gansterer
Comment 5 2011-02-22 12:30:11 PST
Created attachment 83363 [details] Patch
Geoffrey Garen
Comment 6 2011-02-22 12:35:27 PST
Is it safe to call detachThread after calling waitForThreadCompletion?
Alexey Proskuryakov
Comment 7 2011-02-22 12:40:56 PST
I thought that it's one or the other, not both.
Patrick R. Gansterer
Comment 8 2011-02-22 12:42:52 PST
Created attachment 83366 [details] Patch AFAIK it's no problem to do both, but the cleaner way is to to only one of them
Eric Seidel (no email)
Comment 9 2011-04-10 16:28:35 PDT
Comment on attachment 83366 [details] Patch Seems sane to me.
WebKit Commit Bot
Comment 10 2011-04-17 16:08:36 PDT
Comment on attachment 83366 [details] Patch Clearing flags on attachment: 83366 Committed r84113: <http://trac.webkit.org/changeset/84113>
WebKit Commit Bot
Comment 11 2011-04-17 16:08:41 PDT
All reviewed patches have been landed. Closing bug.
WebKit Commit Bot
Comment 12 2011-04-17 16:20:13 PDT
The commit-queue encountered the following flaky tests while processing attachment 83366 [details]: animations/suspend-resume-animation.html bug 48161 (author: cmarrin@apple.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 13 2011-04-17 18:26:55 PDT
The commit-queue encountered the following flaky tests while processing attachment 83366 [details]: http/tests/xmlhttprequest/abort-crash.html bug 51649 (author: andersca@apple.com) The commit-queue is continuing to process your patch.
Note You need to log in before you can comment on or make changes to this bug.