Bug 55641
| Summary: | REGRESSION(r70170) - google images does not work as expected with iphone user agent. | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Luiz Agostini <luiz> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED WORKSFORME | ||
| Severity: | Normal | CC: | abarth, bdakin, christian.webkit, ddkilzer, dev+webkit, hyatt, jamesr, joepeck, jparent, kenneth, kling, mdelaney7, ojan, simon.fraser, zalan |
| Priority: | P2 | Keywords: | InRadar, NeedsReduction, Regression |
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Luiz Agostini
When using iphone user agent, google images does not work as expected. It is a lot more wide that it is supposed to be.
It seems to be happening since https://trac.webkit.org/changeset/70170.
The tests have been made with Qt and the used user agents were:
Mozilla/5.0 (iPhone; U; CPU OS 3_2 like Mac OS X; en-us) AppleWebKit/531.21.10 (KHTML, like Gecko) Version/4.0.4 Mobile/7B334b Safari/531.21.10
Mozilla/5.0 (iPhone; U; CPU iPhone OS 4_0 like Mac OS X; en-us) AppleWebKit/532.9 (KHTML, like Gecko) Version/4.0.5 Mobile/8A293 Safari/6531.22.7
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Kenneth Rohde Christiansen
Info from Andreas Kling who did some bisecting of this:
r64439 works, where as 65682 does not.
Kenneth Rohde Christiansen
Kling you bisecting seems to not match with Luiz findings.
Andreas Kling
(In reply to comment #2)
> Kling you bisecting seems to not match with Luiz findings.
I have the bug on r65268 here FWIW
Kenneth Rohde Christiansen
I should probably make it clean that it doesn't break the google images front page, but the page shown after you have searched for something
Luiz Agostini
I tried again and seems to be on r70170 indeed. We may be testing different issues. What I do is:
1 - select user agent: Mozilla/5.0 (iPhone; U; CPU OS 3_2 like Mac OS X; en-us) AppleWebKit/531.21.10 (KHTML, like Gecko) Version/4.0.4 Mobile/7B334b Safari/531.21.10
2 - go to www.google.com
3 - click on 'imagens' (portuguese)
4 - type 'cars'
5 - enter
On r70169 no horizontal scrollbar is shown. On r70170 a scrollbar can be seen, the content width seems to be twice larger then on r70169 and if you scroll to the right you see the images that are expected to be in the second page.
I am testing on Linux.
David Kilzer (:ddkilzer)
<rdar://problem/9085209>
Kenneth Rohde Christiansen
Hyatt, do you have any idea where to look in order to fix this? like what might have broken it?
Simon Fraser (smfr)
Sounds like taking transformed into account for overflow broke this. Google should fix their site.
Kenneth Rohde Christiansen
(In reply to comment #8)
> Sounds like taking transformed into account for overflow broke this. Google should fix their site.
Eric, do you know who at Google can look into this?
Eric Seidel (no email)
Donno. Other googlers might know someone on the images team.
Matthew Delaney
Adding a few more googlers (probably all the wrong ones, oh well). Do you guys have any internal mechanism for alerting the Google Images team? Or at least a quick way to look up one of their emails to get them on this? Thanks!
Emil A Eklund
FYI: I've forwarded this bug to the google images team.
David Kilzer (:ddkilzer)
Works for me now. I think his can be closed.