Bug 57019

Summary: JavaInstance should not use jvalue in its API
Product: WebKit Reporter: Steve Block <steveblock>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: andreip, commit-queue, jorlow, steveblock
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 57022    
Bug Blocks: 55383    
Attachments:
Description Flags
Patch
none
Patch none

Steve Block
Reported 2011-03-24 08:47:39 PDT
The JavaInstance API should represent a generic Java object and should be independent of JNI, to give embedders flexibility in how a Java object is provided. This means that the API should use a new JavaValue type to represent a Java value, rather than the JNI jvalue type.
Attachments
Patch (6.07 KB, patch)
2011-03-29 04:12 PDT, Steve Block 		no flags
DetailsFormatted DiffDiff
Patch (6.36 KB, patch)
2011-03-29 15:06 PDT, Steve Block 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Steve Block
Comment 1 2011-03-24 08:48:30 PDT
See bug 55383.
Steve Block
Comment 2 2011-03-29 01:19:03 PDT
This bug tracks fixing only the V8 version of JavaInstance. The JSC version can not be fixed until Bug 57023 is fixed.
Steve Block
Comment 3 2011-03-29 04:12:53 PDT
Created attachment 87296 [details] Patch
Andrei Popescu
Comment 4 2011-03-29 11:31:12 PDT
LGTM View in context: https://bugs.webkit.org/attachment.cgi?id=87296&action=review > Source/WebCore/bridge/jni/v8/JavaInstanceV8.cpp:76 > + jvalue* jvalueArgs = new jvalue[numParams]; Is there a scoped_pointer for arrays? > Source/WebCore/bridge/jni/v8/JavaInstanceV8.cpp:78 > + jvalueArgs[i] = javaValueToJvalue(args[i]); Maybe add a comment to say that args is guaranteed to have at least numParams elements.
Steve Block
Comment 5 2011-03-29 15:03:56 PDT
> Is there a scoped_pointer for arrays? Yes - OwnArrayPtr - fixed. > Maybe add a comment to say that args is guaranteed to have at least numParams elements. I've added a comment in the header. Note that this is not a new requirement, as previously the array was passed straight through to callJNIMethod().
Steve Block
Comment 6 2011-03-29 15:06:50 PDT
Created attachment 87413 [details] Patch
Jeremy Orlow
Comment 7 2011-03-29 15:10:26 PDT
Comment on attachment 87413 [details] Patch r+ based on Andrei's review
WebKit Commit Bot
Comment 8 2011-03-29 16:47:03 PDT
Comment on attachment 87413 [details] Patch Clearing flags on attachment: 87413 Committed r82361: <http://trac.webkit.org/changeset/82361>
WebKit Commit Bot
Comment 9 2011-03-29 16:47:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.