Bug 57575

Summary: NRWT shouldn't copy .checksum files if the checksum is in the png
Product: WebKit Reporter: Tony Chang <tony>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: dpranke, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 56286    
Attachments:
Description Flags
Patch ojan: review+

Tony Chang
Reported 2011-03-31 14:03:58 PDT
Currently running --reset-results and --new-baseline always copies over the .checksum file, even if the checksum is in the png comment. Once we don't need the .checksum file, we can remove this copy step. We also need to delete any old .checksum files that may exist from previous baselines.
Attachments
Patch (4.84 KB, patch)
2011-04-13 15:54 PDT, Tony Chang 		ojan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2011-04-13 15:54:54 PDT
Created attachment 89482 [details] Patch
Tony Chang
Comment 2 2011-04-14 10:58:28 PDT
Per discussion on 58402, I won't land this until I've updated all the existing pngs.
Tony Chang
Comment 3 2011-04-21 10:53:53 PDT
I'm going to merge this into a single patch in bug 58402. *** This bug has been marked as a duplicate of bug 58402 ***
Note You need to log in before you can comment on or make changes to this bug.