Bug 57839

Summary:

[Qt] [Symbian] the include file for symbian should be case sensitive

Product:

WebKit

Reporter:

Liang Qi <liang.qi>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, commit-queue, jturcotte, s.mathur

Priority:

Keywords:

Qt, QtTriaged

Version:

528+ (Nightly build)

Hardware:

S60 Hardware

OS:

S60 3rd edition

Attachments:

Description	Flags
A patch to fix the include file name for wtf/PageAllocatorSymbian.h	none
A patch to fix the include file name for wtf/PageAllocatorSymbian.h	none
A patch to fix the include file name for wtf/PageAllocatorSymbian.h	benjamin: review+, commit-queue: commit-queue-
A patch to fix the include file name for wtf/PageAllocatorSymbian.h	none

Liang Qi

Reported 2011-04-05 06:19:37 PDT

In Source/JavaScriptCore/wtf/PageAllocatorSymbian.h, it includes #include <wtf/BitMap.h> But the real file name is Bitmap.h. Then it should be #include <wtf/Bitmap.h> Otherwise, it will break the makefile build system for armcc & gcce.

Attachments
A patch to fix the include file name for wtf/PageAllocatorSymbian.h (1.07 KB, patch) 2011-04-05 06:25 PDT, Liang Qi	no flags	Details Formatted Diff Diff
A patch to fix the include file name for wtf/PageAllocatorSymbian.h (1018 bytes, patch) 2011-04-05 06:57 PDT, Liang Qi	no flags	Details Formatted Diff Diff
A patch to fix the include file name for wtf/PageAllocatorSymbian.h (1020 bytes, patch) 2011-04-05 07:02 PDT, Liang Qi	benjamin: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
A patch to fix the include file name for wtf/PageAllocatorSymbian.h (980 bytes, patch) 2011-04-06 08:09 PDT, Liang Qi	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Liang Qi

Comment 1 2011-04-05 06:25:28 PDT

Created attachment 88217 [details] A patch to fix the include file name for wtf/PageAllocatorSymbian.h

Jocelyn Turcotte

Comment 2 2011-04-05 06:34:57 PDT

Some stuff to fix in you Changelog entry: - Specify this bug's URL instead of the bug number for quick access. - Leave a blank line between the URL and the patch long description. - In "Correct a include file name.", "a" should be written "an". See there if you want more information: http://trac.webkit.org/wiki/QtWebKitContrib Have a look at previous entries in Changelogs, this should give you a reliable template.

Jocelyn Turcotte

Comment 3 2011-04-05 06:37:55 PDT

Don't forget to press Details on your attachment and set the review flag to "?" if you want your patch to appear in the review queue ( webkit.org/pending-review ). Set the commit-queue flag to "?" as well if you want your patch to be committed automatically once it got approved.

Siddharth Mathur

Comment 4 2011-04-05 06:38:25 PDT

Please also fix the rationale to simply say that "Use correct case of file name so as to work on Unix/Linux build hosts" or similar. This has nothing to do with Makefile/ARMCC/GCCE

Liang Qi

Comment 5 2011-04-05 06:57:05 PDT

Created attachment 88220 [details] A patch to fix the include file name for wtf/PageAllocatorSymbian.h Update the changelog.

Siddharth Mathur

Comment 6 2011-04-05 06:59:40 PDT

(In reply to comment #5) > Created an attachment (id=88220) [details] > A patch to fix the include file name for wtf/PageAllocatorSymbian.h > > Update the changelog. Looks good. Many thanks. ( I am not a reviewer, so someone else will have to bless it with r+)

Liang Qi

Comment 7 2011-04-05 07:02:25 PDT

Created attachment 88221 [details] A patch to fix the include file name for wtf/PageAllocatorSymbian.h

Benjamin Poulain

Comment 8 2011-04-06 04:45:53 PDT

Comment on attachment 88221 [details] A patch to fix the include file name for wtf/PageAllocatorSymbian.h Good catch.

WebKit Commit Bot

Comment 9 2011-04-06 04:48:52 PDT

Comment on attachment 88221 [details] A patch to fix the include file name for wtf/PageAllocatorSymbian.h Rejecting attachment 88221 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-8', 'apply-..." exit_code: 2 Last 500 characters of output: iled to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Benjamin Poulain', u'-..." exit_code: 2 Parsed 2 diffs from patch file(s). patching file Source/JavaScriptCore/ChangeLog patch: **** malformed patch at line 17: 2011-04-05 Nikolas Zimmermann <nzimmermann@rim.com> patching file Source/JavaScriptCore/wtf/PageAllocatorSymbian.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Benjamin Poulain', u'-..." exit_code: 2 Full output: http://queues.webkit.org/results/8341193

Liang Qi

Comment 10 2011-04-06 08:09:37 PDT

Created attachment 88423 [details] A patch to fix the include file name for wtf/PageAllocatorSymbian.h

Benjamin Poulain

Comment 11 2011-04-06 08:10:38 PDT

Comment on attachment 88423 [details] A patch to fix the include file name for wtf/PageAllocatorSymbian.h Let's try again.

WebKit Commit Bot

Comment 12 2011-04-06 09:07:19 PDT

The commit-queue encountered the following flaky tests while processing attachment 88423 [details]: java/lc3/JSObject/ToObject-001.html bug 53091 (author: ap@webkit.org) The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 13 2011-04-06 09:09:35 PDT

Comment on attachment 88423 [details] A patch to fix the include file name for wtf/PageAllocatorSymbian.h Clearing flags on attachment: 88423 Committed r83059: <http://trac.webkit.org/changeset/83059>

WebKit Commit Bot

Comment 14 2011-04-06 09:09:40 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.