Bug 57841

Created attachment 88219 [details] The fix for Enable webkit build for the makefile build system with gcce

Looks Ok to me, though you fix that Changelog entry to better match other prior entries. (I hope you are aware that only the RVCT 4.0 driven Symbian configuration will get bug fixes and performance tuning going forward, not GCC(E) for Symbian).

Comment on attachment 88219 [details] The fix for Enable webkit build for the makefile build system with gcce View in context: https://bugs.webkit.org/attachment.cgi?id=88219&action=review > Source/JavaScriptCore/wtf/MathExtras.h:241 > +#if !COMPILER(MSVC) && !COMPILER(WINSCW) && !(COMPILER(RVCT) && (OS(SYMBIAN) || PLATFORM(BREWMP))) && !OS(SOLARIS) && !(COMPILER(GCC) && OS(SYMBIAN)) You should use the OS(SYMBIAN) part already in the statement, e.g. : ... && ((OS(SYMBIAN) && !COMPILER(GCC)) || PLATFORM(BREWMP))) && ... > Source/WebCore/WebCore.pri:-149 > - MMP_RULES += ALWAYS_BUILD_AS_ARM What happenned with the MMP_RULES statement? > Source/WebCore/WebCore.pri:150 > + CONFIG += do_not_build_as_thumb Thumb was only disabled for Linux armcc builds, now you disable it for all builds, is this intentional?

Please check $QTDIR/mkspecs/features/symbian/do_not_build_as_thumb.prf Those old things are moved there.

(In reply to comment #3) > > Source/JavaScriptCore/wtf/MathExtras.h:241 > > +#if !COMPILER(MSVC) && !COMPILER(WINSCW) && !(COMPILER(RVCT) && (OS(SYMBIAN) || PLATFORM(BREWMP))) && !OS(SOLARIS) && !(COMPILER(GCC) && OS(SYMBIAN)) > > You should use the OS(SYMBIAN) part already in the statement, e.g. : > ... && ((OS(SYMBIAN) && !COMPILER(GCC)) || PLATFORM(BREWMP))) && ... > Forget that part, I didn't see the RVCT compiler part.

Created attachment 88296 [details] The fix for Enable webkit build for the makefile build system with gcce

Created attachment 88428 [details] The fix for Enable webkit build for the makefile build system with gcce

Attachment 88428 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style']" exit_code: 1 Source/JavaScriptCore/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.

Created attachment 88429 [details] Enable webkit build with GCCE on Symbian.

Comment on attachment 88429 [details] Enable webkit build with GCCE on Symbian. View in context: https://bugs.webkit.org/attachment.cgi?id=88429&action=review Great progress! LGTM. > Source/WebCore/WebCore.pri:-149 > - MMP_RULES += ALWAYS_BUILD_AS_ARM Isn't this needed any more?

(In reply to comment #10) > > Source/WebCore/WebCore.pri:-149 > > - MMP_RULES += ALWAYS_BUILD_AS_ARM > > Isn't this needed any more? I answered this in comment #4 https://bugs.webkit.org/show_bug.cgi?id=57841#c4

>CONFIG += do_not_build_as_thumb That is now on for all configurations? Or is there symbian - scope somewhere outside diff ? Otherwise looks good to me. Did you encouter build issues with missing atomicity.h ? I recall I had to hack that out when building QtWebkit with GCCE 4.4.1.

Yes, there is a symbian scope outside of this patch. And there is no issue about missing atomicity.h, I am using S^3 PDK 3.0.x. Build the qtwebkit both from 4.7 and trunk are fine.

I applied this patch to arm build (relase) for symbian target, with SVG enabled. The build is fine (literally unchanged, for that target) but an existing issue with executing webkit apps remains, because the code segment exceeds the configured 0xE00000 for arm and gets overwitten by data segment. If the patch would apply the same GCCE value 0x1000000 for armcc as well, the SVG runtime issue will be resolved. I suggest to update the patch for WebKit.pri: - QMAKE_LFLAGS.ARMCC += --rw-base 0xE00000 + QMAKE_LFLAGS.ARMCC += --rw-base 0x1000000 The comment lines before that also need to be updated accordingly.

Comment on attachment 88429 [details] Enable webkit build with GCCE on Symbian. r- to include Norbert's finding as well in the same patch as I think it is related. Make sure the comment lines are updated as well.

Created attachment 88631 [details] Enable webkit build with GCCE on Symbian Add the change for RVCT. Update the changelog.

Comment on attachment 88631 [details] Enable webkit build with GCCE on Symbian r=me. Thanks.

Comment on attachment 88631 [details] Enable webkit build with GCCE on Symbian Clearing flags on attachment: 88631 Committed r83179: <http://trac.webkit.org/changeset/83179>

All reviewed patches have been landed. Closing bug.

This was also commited to Qt-4.7 (http://bugreports.qt.nokia.com/browse/QTBUG-18484) and therefore needs to be cherry-picked into qtwebkit-2.0 and qtwebkit-2.1.