Bug 58560

Summary:

Port Mozilla's IndexedDB test cases to WebKit

Product:

WebKit

Reporter:

Mark Pilgrim (Google) <pilgrim>

Component:

New Bugs

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

andreip, dgrogan, fishd, hans, pilgrim

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
first draft of tests (incomplete)	none
second draft of tests (incomplete)	none
third draft of tests (incomplete)	none

Mark Pilgrim (Google)

Reported 2011-04-14 11:49:37 PDT

Specifically, these tests: http://mxr.mozilla.org/mozilla2.0/source/dom/indexedDB/test/

Attachments
first draft of tests (incomplete) (61.07 KB, patch) 2011-04-14 11:52 PDT, Mark Pilgrim (Google)	no flags	Details Formatted Diff Diff
second draft of tests (incomplete) (80.72 KB, patch) 2011-04-14 17:57 PDT, Mark Pilgrim (Google)	no flags	Details Formatted Diff Diff
third draft of tests (incomplete) (116.66 KB, patch) 2011-04-15 10:45 PDT, Mark Pilgrim (Google)	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Mark Pilgrim (Google)

Comment 1 2011-04-14 11:52:29 PDT

Created attachment 89618 [details] first draft of tests (incomplete) For informal review only.

Mark Pilgrim (Google)

Comment 2 2011-04-14 11:54:10 PDT

*** Bug 58356 has been marked as a duplicate of this bug. ***

Mark Pilgrim (Google)

Comment 3 2011-04-14 11:54:33 PDT

*** Bug 58368 has been marked as a duplicate of this bug. ***

Darin Fisher (:fishd, Google)

Comment 4 2011-04-14 13:11:53 PDT

hans, david, andrei: it'd be great if you could review this!

Mark Pilgrim (Google)

Comment 5 2011-04-14 17:57:38 PDT

Created attachment 89706 [details] second draft of tests (incomplete) Changed webkitIndexedDB to unprefixed + our prefix + Moz prefix, as per discussion with dgrogan. Also added several new tests (key-requirements-*)

Mark Pilgrim (Google)

Comment 6 2011-04-15 10:45:40 PDT

Created attachment 89809 [details] third draft of tests (incomplete) more tests added for versionchange event, getting put values, aborting setVersion, syntax variations in readonly and read/write transactions, and getting after an aborted transaction

David Grogan

Comment 7 2011-04-15 12:33:22 PDT

The stuff below is copy/pasted because I don't have permission to edit bugs. Do I have to become a webkit committer before I can edit bugs? View in context: https://bugs.webkit.org/attachment.cgi?id=89809&action=review These look good. Though I only know much about connection-related stuff like open, close, and setVersion. Hans, do you want to quick-glance for objectstore, index, etc. suboptimalities? > third_party/WebKit/LayoutTests/storage/indexeddb/mozilla/versionchange.html:45 > + request.onblocked = unexpectedErrorCallback; There's an unexpectedBlockCallback or unexpectedBlockedCallback (extra "ed") that you can use.

Mark Pilgrim (Google)

Comment 8 2011-04-27 14:40:05 PDT

Split into several bugs. *** This bug has been marked as a duplicate of bug 59492 ***

Note You need to log in before you can comment on or make changes to this bug.