Bug 59664

Summary: Fix OwnPtr strict issues in chromium linux build
Product: WebKit Reporter: James Robinson <jamesr>
Component: New BugsAssignee: James Robinson <jamesr>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, kbr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 59666    
Attachments:
Description Flags
Patch abarth: review+

James Robinson
Reported 2011-04-27 18:22:13 PDT
Fix OwnPtr strict issues in chromium linux build
Attachments
Patch (5.62 KB, patch)
2011-04-27 18:22 PDT, James Robinson 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Robinson
Comment 1 2011-04-27 18:22:42 PDT
Created attachment 91395 [details] Patch
Adam Barth
Comment 2 2011-04-27 18:27:37 PDT
Comment on attachment 91395 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91395&action=review > Source/WebKit/chromium/src/WebImageDecoder.cpp:115 > - OwnPtr<NativeImageSkia>image(frameBuffer->asNewNativeImage()); > + OwnPtr<NativeImageSkia> image(adoptPtr(frameBuffer->asNewNativeImage())); We usually prefer the = form of the constructor.
James Robinson
Comment 3 2011-04-27 18:42:31 PDT
Committed r85135: <http://trac.webkit.org/changeset/85135>
Note You need to log in before you can comment on or make changes to this bug.