Bug 59889

Summary: [android] Let the buildsystem select the feature set
Product: WebKit Reporter: Holger Freyther <zecke>
Component: New BugsAssignee: Holger Freyther <zecke>
Status: RESOLVED INVALID    
Severity: Normal CC: abarth, eric, steveblock
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 60907    
Attachments:
Description Flags
Patch
none
Patch none

Holger Freyther
Reported 2011-05-01 14:01:32 PDT
[android] Let the buildsystem select the feature set
Attachments
Patch (3.97 KB, patch)
2011-05-01 14:08 PDT, Holger Freyther 		no flags
DetailsFormatted DiffDiff
Patch (3.98 KB, patch)
2011-05-13 07:57 PDT, Holger Freyther 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Holger Freyther
Comment 1 2011-05-01 14:08:13 PDT
Created attachment 91841 [details] Patch
Adam Barth
Comment 2 2011-05-11 21:11:49 PDT
Comment on attachment 91841 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91841&action=review Generally, I'm supportive of this change, but we should make sure it's compatible with the Android.mk build system. > Source/JavaScriptCore/ChangeLog:8 > + Instead of having two fights enable and disable and undo fights => fighting > Source/JavaScriptCore/wtf/Platform.h:673 > #define ENABLE_TEXT_CARET 1 Why not move this one as well?
Steve Block
Comment 3 2011-05-12 02:17:35 PDT
Comment on attachment 91841 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=91841&action=review >> Source/JavaScriptCore/wtf/Platform.h:673 >> #define ENABLE_TEXT_CARET 1 > > Why not move this one as well? Agreed - if we're to move most of these, why not move them all?
Holger Freyther
Comment 4 2011-05-12 08:19:27 PDT
(In reply to comment #3) > >> Source/JavaScriptCore/wtf/Platform.h:673 > >> #define ENABLE_TEXT_CARET 1 > > > > Why not move this one as well? > > Agreed - if we're to move most of these, why not move them all? I mostly looked if someone else is doing it and found that iOS does. So right now there is no buildsystem support for this feature and I thought of it as something 'fundamental' defined by the platform. My example is a bit bad... I thought of it is as something like the double click interval (defined by the platform).
Steve Block
Comment 5 2011-05-12 08:22:49 PDT
Android's use of the Java bridge is no more or less fundamental than it's use of other optional features, so I think we should keep these together, even if that means adding support to the build system.
Holger Freyther
Comment 6 2011-05-12 08:29:52 PDT
(In reply to comment #5) > Android's use of the Java bridge is no more or less fundamental than it's use of other optional features, so I think we should keep these together, even if that means adding support to the build system. In that case I agree. Is there anything else you think is wrong with the patch?
Steve Block
Comment 7 2011-05-12 08:35:02 PDT
I don't think there's anything wrong with this patch in itself, but I'm confused about your overall plan. It would be good if you could answer my questions in https://bugs.webkit.org/show_bug.cgi?id=59892#c6.
Holger Freyther
Comment 8 2011-05-13 07:57:09 PDT
Created attachment 93452 [details] Patch
Holger Freyther
Comment 9 2011-06-20 00:32:57 PDT
Parts of the patch are obsoleted by Steve's change in bug #62602.
Steve Block
Comment 10 2011-08-23 05:15:35 PDT
Comment on attachment 93452 [details] Patch As you mention, this patch is largely obsoleted by recent changes to remove PLATFORM(ANDROID), so I'm removing the r? flag. See Bug 66688.
Steve Block
Comment 11 2011-10-06 04:49:43 PDT
This is obsolete now that Android is using the Chromium port. See Bug 66687.
Note You need to log in before you can comment on or make changes to this bug.