Bug 60080

Summary: Split createLineBoxesFromBidiRuns out from layoutRunsAndFloats
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, leviw, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 36921    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Eric Seidel (no email)
Reported 2011-05-03 16:20:13 PDT
Split createLineBoxesFromBidiRuns out from layoutRunsAndFloats
Attachments
Patch (8.00 KB, patch)
2011-05-03 16:24 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch (8.02 KB, patch)
2011-05-03 16:29 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.87 KB, patch)
2011-05-03 17:01 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-05-03 16:24:08 PDT
Created attachment 92161 [details] Patch
Eric Seidel (no email)
Comment 2 2011-05-03 16:29:00 PDT
Created attachment 92163 [details] Patch
Ryosuke Niwa
Comment 3 2011-05-03 16:58:58 PDT
Comment on attachment 92163 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=92163&action=review > Source/WebCore/rendering/RenderBlockLineLayout.cpp:930 > + if (bidiRuns.runCount() && hyphenated) > + bidiRuns.logicallyLastRun()->m_hasHyphen = true; > + > BidiRun* trailingSpaceRun = !lineInfo.previousLineBrokeCleanly() ? handleTrailingSpaces(bidiRuns, resolver.context()) : 0; Are you certain that handleTrailingSpaces won't be affected by assigning the value to m_hasHyphen earlier?
Eric Seidel (no email)
Comment 4 2011-05-03 17:01:40 PDT
Created attachment 92172 [details] Patch for landing
WebKit Commit Bot
Comment 5 2011-05-04 04:49:53 PDT
The commit-queue encountered the following flaky tests while processing attachment 92172 [details]: http/tests/inspector/console-websocket-error.html bug 57392 (authors: pfeldman@chromium.org and yutak@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 6 2011-05-04 04:51:19 PDT
Comment on attachment 92172 [details] Patch for landing Clearing flags on attachment: 92172 Committed r85732: <http://trac.webkit.org/changeset/85732>
WebKit Commit Bot
Comment 7 2011-05-04 04:51:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.