Bug 60230

Summary: [chromium] Rebaseline various media tests after controls absolute positioning changes
Product: WebKit Reporter: Steve Lacey <sjl>
Component: Layout and RenderingAssignee: Steve Lacey <sjl>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Steve Lacey
Reported 2011-05-04 16:45:45 PDT
Rebaseline of various media tests for chromium port.
Attachments
Patch (1.40 MB, patch)
2011-05-04 16:50 PDT, Steve Lacey 		no flags
DetailsFormatted DiffDiff
Patch (1.40 MB, patch)
2011-05-05 14:34 PDT, Steve Lacey 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Steve Lacey
Comment 1 2011-05-04 16:50:09 PDT
Created attachment 92347 [details] Patch
Steve Lacey
Comment 2 2011-05-05 13:31:32 PDT
Comment on attachment 92347 [details] Patch Removing review and commit request as I want to take a more detailed look at these results.
Steve Lacey
Comment 3 2011-05-05 13:43:24 PDT
Comment on attachment 92347 [details] Patch All checked and no dupes found.
WebKit Commit Bot
Comment 4 2011-05-05 14:16:47 PDT
Comment on attachment 92347 [details] Patch Rejecting attachment 92347 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'apply-..." exit_code: 2 Last 500 characters of output: .txt patching file LayoutTests/platform/chromium-win/media/video-no-audio-expected.txt patching file LayoutTests/platform/chromium-win/media/video-volume-slider-expected.txt patching file LayoutTests/platform/chromium/test_expectations.txt Hunk #1 FAILED at 3660. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Eric Carlson', u'--for..." exit_code: 1 Full output: http://queues.webkit.org/results/8590003
Steve Lacey
Comment 5 2011-05-05 14:34:38 PDT
Created attachment 92470 [details] Patch
Steve Lacey
Comment 6 2011-05-05 14:35:09 PDT
Fixed conflict.
Eric Seidel (no email)
Comment 7 2011-05-05 14:45:16 PDT
Comment on attachment 92470 [details] Patch OK.
WebKit Commit Bot
Comment 8 2011-05-05 16:52:11 PDT
The commit-queue encountered the following flaky tests while processing attachment 92470 [details]: http/tests/inspector/console-websocket-error.html bug 57392 (authors: pfeldman@chromium.org and yutak@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 9 2011-05-05 16:55:15 PDT
Comment on attachment 92470 [details] Patch Clearing flags on attachment: 92470 Committed r85899: <http://trac.webkit.org/changeset/85899>
WebKit Commit Bot
Comment 10 2011-05-05 16:55:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.