Bug 60437

Summary: Added missing DATABASE macro
Product: WebKit Reporter: Tomasz Morawski <t.morawski>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, gyuyoung.kim, lucas.de.marchi, rakuco
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Linux   
Attachments:
Description Flags
Patch
none
Patch 2
dbates: review+
Patch 3
kling: review+, lucas.de.marchi: commit-queue-
Patch 4 none

Tomasz Morawski
Reported 2011-05-07 09:34:30 PDT
Added missing DATABASE macro in ewk_settings.cpp file.
Attachments
Patch (1.36 KB, patch)
2011-05-07 09:39 PDT, Tomasz Morawski 		no flags
DetailsFormatted DiffDiff
Patch 2 (1.43 KB, patch)
2011-05-07 09:44 PDT, Tomasz Morawski 		dbates: review+
DetailsFormatted DiffDiff
Patch 3 (1.43 KB, patch)
2011-05-07 22:39 PDT, Tomasz Morawski 		kling: review+
lucas.de.marchi: commit-queue-
DetailsFormatted DiffDiff
Patch 4 (1.38 KB, patch)
2011-05-11 00:43 PDT, Tomasz Morawski 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Tomasz Morawski
Comment 1 2011-05-07 09:39:32 PDT
Created attachment 92691 [details] Patch
Tomasz Morawski
Comment 2 2011-05-07 09:44:57 PDT
Created attachment 92692 [details] Patch 2
Daniel Bates
Comment 3 2011-05-07 14:31:40 PDT
Comment on attachment 92692 [details] Patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=92692&action=review rs=me > Source/WebKit/efl/ewk/ewk_settings.cpp:96 > + return _ewk_default_web_database_quota; The spacing seems to be off here by one space character.
Tomasz Morawski
Comment 4 2011-05-07 22:39:53 PDT
Created attachment 92727 [details] Patch 3
Lucas De Marchi
Comment 5 2011-05-09 05:15:04 PDT
Comment on attachment 92727 [details] Patch 3 LGTM
WebKit Commit Bot
Comment 6 2011-05-09 07:09:55 PDT
Comment on attachment 92727 [details] Patch 3 Rejecting attachment 92727 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'land-a..." exit_code: 1 Last 500 characters of output: ebCore/platform/graphics/ca/GraphicsLayerCA.cpp r86051 = 06f401359be7b4b6ee7c0f35b6c47ab3b3f5badf (refs/remotes/trunk) M Source/WebCore/ChangeLog M Source/WebCore/WebCore.vcproj/WebCore.vcproj r86052 = 9fe0a47c5421a8afbd9f3f92525ebc9a5783a97f (refs/remotes/trunk) M LayoutTests/platform/qt/Skipped M LayoutTests/ChangeLog r86053 = d8690d6cfb3d4e89edcf4a272c5e20a02f2072e0 (refs/remotes/trunk) First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/trunk. Full output: http://queues.webkit.org/results/8655538
WebKit Commit Bot
Comment 7 2011-05-09 08:26:40 PDT
The commit-queue encountered the following flaky tests while processing attachment 92727 [details]: java/lc3/JSObject/ToObject-001.html bug 53091 (author: ap@webkit.org) java/lc3/ConvertUndefined/undefined-003.html bug 60470 (author: ap@webkit.org) The commit-queue is continuing to process your patch.
Tomasz Morawski
Comment 8 2011-05-10 06:12:39 PDT
Comment on attachment 92727 [details] Patch 3 I don't know what was happened... so, I one time more set commit-queue
Lucas De Marchi
Comment 9 2011-05-10 07:29:28 PDT
(In reply to comment #8) > (From update of attachment 92727 [details]) > I don't know what was happened... so, I one time more set commit-queue Your changelog is wrong... See the error: ERROR: /mnt/git/webkit-commit-queue/Source/WebKit/efl/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Tomasz Morawski
Comment 10 2011-05-10 07:38:38 PDT
(In reply to comment #9) > (In reply to comment #8) > > (From update of attachment 92727 [details] [details]) > > I don't know what was happened... so, I one time more set commit-queue > > Your changelog is wrong... See the error: > > > ERROR: /mnt/git/webkit-commit-queue/Source/WebKit/efl/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Why style script doesn't show it?
Tomasz Morawski
Comment 11 2011-05-11 00:43:48 PDT
Created attachment 93082 [details] Patch 4
Tomasz Morawski
Comment 12 2011-05-11 00:44:53 PDT
(In reply to comment #9) Thank you, could you review my the last one patch?
Gyuyoung Kim
Comment 13 2011-05-11 00:57:36 PDT
LGTM. Demarchi, how do you think ?
Lucas De Marchi
Comment 14 2011-05-11 05:30:09 PDT
Comment on attachment 93082 [details] Patch 4 LGTM. I manually applied this patch. http://trac.webkit.org/changeset/86227 Clearing flags.
Note You need to log in before you can comment on or make changes to this bug.