Bug 60640

Summary: Replace IntPoint with const IntPoint& in RenderFlexibleBox::placeChild
Product: WebKit Reporter: Emil A Eklund <eae>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, darin
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch for landing none

Emil A Eklund
Reported 2011-05-11 10:32:15 PDT
Follow up from bug 60592: Use const IntPoint& instead of just IntPoint to avoid extra constructor overhead.
Attachments
Patch (1.93 KB, patch)
2011-05-11 12:38 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.01 KB, patch)
2011-05-12 14:13 PDT, Emil A Eklund 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Emil A Eklund
Comment 1 2011-05-11 12:38:05 PDT
Created attachment 93158 [details] Patch
Alexey Proskuryakov
Comment 2 2011-05-11 15:26:10 PDT
This patch seems fine in that in brings this particular function in line with what we normally do, but it's more than cleanup. I'm not an expert, but I suspect that this negatively affects performance on at least some platforms.
Emil A Eklund
Comment 3 2011-05-11 15:37:52 PDT
Alexey, that's a valid point. Would you like me to update the description or discard the patch?
Alexey Proskuryakov
Comment 4 2011-05-11 17:15:13 PDT
I talked to Maciej, and he suggested that this patch is fine to land for consistency, but it would be good to investigate this deeper in a follow up bug. Sounded right to me!
Emil A Eklund
Comment 5 2011-05-11 17:26:51 PDT
Cool, thanks!
Emil A Eklund
Comment 6 2011-05-12 14:13:41 PDT
Created attachment 93339 [details] Patch for landing
WebKit Commit Bot
Comment 7 2011-05-12 15:32:07 PDT
Comment on attachment 93339 [details] Patch for landing Clearing flags on attachment: 93339 Committed r86389: <http://trac.webkit.org/changeset/86389>
WebKit Commit Bot
Comment 8 2011-05-12 15:32:12 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.