Bug 62199

Summary: new-run-webkit-tests: support --repeat-each feature from old-run-webkit-tests
Product: WebKit Reporter: Mikhail Naganov <mnaganov>
Component: Tools / TestsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, eric, inferno, ojan, rniwa, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 64491    
Attachments:
Description Flags
Patch none

Mikhail Naganov
Reported 2011-06-07 02:39:39 PDT
This is a really useful thing for reproducing flaky test failures. What I'm doing now is replicating my test into a thousand files with different names, and passing them to nwrt.
Attachments
Patch (4.51 KB, patch)
2011-11-06 23:46 PST, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-10-27 16:06:46 PDT
*** Bug 65894 has been marked as a duplicate of this bug. ***
Eric Seidel (no email)
Comment 2 2011-11-06 23:46:52 PST
Created attachment 113828 [details] Patch
Eric Seidel (no email)
Comment 3 2011-11-06 23:48:24 PST
Dirk: I assume it's kosher that I'm making self._test_files_list out of sync (count-wise) with self._test_files? I mean, I guess it's not really out of sync since the list would still colapse down to a set, but there are repeats in self._test_files_list. I assume this approximately matches what NRWT would do if I passed it: new-run-webkit-tests foo.html foo.html
Dirk Pranke
Comment 4 2011-11-07 11:45:33 PST
Comment on attachment 113828 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113828&action=review > Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:507 > + # FIXME: It's unclear how --repeat-each and --iterations should interact with chunks? I'd probably just make them mutually exclusive for now. chunks are only used on the bots and aren't likely to need either of those flags. Change looks fine. I'm cq-'ing it in case you want to make the flags mutually exclusive as I suggest (and possibly add some tests enforcing that). I don't feel strongly about it, however, so you can leave things as-is or just update the fixme to say that you should make them mutually exclusive at some point.
Eric Seidel (no email)
Comment 5 2011-11-07 12:25:09 PST
Comment on attachment 113828 [details] Patch Thanks for the review! I think I'll just leave the code as-is for now, and see if anyone complains. :) I think the behavior as written is reasonable, and probably slightly better than an assert.
WebKit Review Bot
Comment 6 2011-11-07 12:42:49 PST
Comment on attachment 113828 [details] Patch Clearing flags on attachment: 113828 Committed r99461: <http://trac.webkit.org/changeset/99461>
WebKit Review Bot
Comment 7 2011-11-07 12:42:54 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.