Bug 62692

Summary: [CMAKE][WK2] include cmakeconfig.h in WebKit2/config.h
Product: WebKit Reporter: Ryuan Choi <ryuan.choi>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, leandro, lucas.de.marchi, rakuco, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 61838    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Ryuan Choi
Reported 2011-06-14 20:08:20 PDT
Patch will be updated.
Attachments
Patch (1.32 KB, patch)
2011-06-14 23:50 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (2.09 KB, patch)
2011-06-15 22:27 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Patch (2.03 KB, patch)
2011-06-15 22:37 PDT, Ryuan Choi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ryuan Choi
Comment 1 2011-06-14 23:50:05 PDT
Created attachment 97241 [details] Patch
Raphael Kubo da Costa (:rakuco)
Comment 2 2011-06-15 05:57:59 PDT
Looks OK to me, informal r+.
Lucas De Marchi
Comment 3 2011-06-15 07:08:03 PDT
Comment on attachment 97241 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97241&action=review > Source/WebKit2/config.h:61 > -#if defined(BUILDING_QT__) || defined(BUILDING_GTK__) > +#if defined(BUILDING_QT__) || defined(BUILDING_GTK__) || defined(BUILDING_WITH_CMAKE) > > #define WTF_USE_JSC 1 > #define WTF_USE_V8 0 This one looks wrong to me. Isn't there any port that might want WTF_USE_V8? Wasn't the EFL port recently adding support to use V8 instead of JSC?
Ryuan Choi
Comment 4 2011-06-15 16:36:15 PDT
(In reply to comment #3) > (From update of attachment 97241 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=97241&action=review > > > Source/WebKit2/config.h:61 > > -#if defined(BUILDING_QT__) || defined(BUILDING_GTK__) > > +#if defined(BUILDING_QT__) || defined(BUILDING_GTK__) || defined(BUILDING_WITH_CMAKE) > > > > #define WTF_USE_JSC 1 > > #define WTF_USE_V8 0 > > This one looks wrong to me. Isn't there any port that might want WTF_USE_V8? Wasn't the EFL port recently adding support to use V8 instead of JSC? Right, it's not good, but I don't know that webkit2 supports v8 now. But, I'll check once more to find better way. BTW, WebKit/EFL doesn't support to use v8 yet. I am waiting Bug 61350 and need to clean up other local patches because it's too old. :( Thanks.
Ryuan Choi
Comment 5 2011-06-15 22:27:56 PDT
Created attachment 97400 [details] Patch
Ryuan Choi
Comment 6 2011-06-15 22:37:00 PDT
Created attachment 97402 [details] Patch
Eric Seidel (no email)
Comment 7 2011-09-12 15:36:32 PDT
Comment on attachment 97402 [details] Patch rs=me.
WebKit Review Bot
Comment 8 2011-09-12 20:29:50 PDT
Comment on attachment 97402 [details] Patch Clearing flags on attachment: 97402 Committed r95005: <http://trac.webkit.org/changeset/95005>
WebKit Review Bot
Comment 9 2011-09-12 20:29:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.