Bug 62967

Summary: [EFL] Remove dead code related with Ewk_Tiled_Backing_Store_Item’s update field.
Product: WebKit Reporter: KwangHyuk <hyuki.kim>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: antognolli+webkit, gyuyoung.kim, gyuyoung.kim, kenneth, leandro, lucas.de.marchi, rakuco, sangseok.lim, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Linux   
Attachments:
Description Flags
propose a simple patch none

KwangHyuk
Reported 2011-06-20 01:16:46 PDT
As Ewk_Tiled_Backing_Store_Item’s update field is not used through ewk and it just causes condition check through some APIs, some dead code related with this field are better to be removed.
Attachments
propose a simple patch (7.82 KB, patch)
2011-06-20 21:36 PDT, KwangHyuk 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
KwangHyuk
Comment 1 2011-06-20 21:36:58 PDT
Created attachment 97926 [details] propose a simple patch
Gyuyoung Kim
Comment 2 2011-06-21 19:19:30 PDT
Rafael, how do you think about this patch ?
Leandro Pereira
Comment 3 2011-06-22 07:36:49 PDT
Comment on attachment 97926 [details] propose a simple patch Informal r+.
Leandro Pereira
Comment 4 2011-06-22 07:39:41 PDT
(In reply to comment #2) > Rafael, how do you think about this patch ? There are other changes pending to be upstreamed on EFL tiled backing store; this patch actually makes it pretty similar to the version we have internally. I'm giving an informal r+ here -- I'll rebase the internal changes later.
Kenneth Rohde Christiansen
Comment 5 2011-06-27 00:32:56 PDT
Comment on attachment 97926 [details] propose a simple patch Great stuff - away with dead code :-)
WebKit Review Bot
Comment 6 2011-06-27 01:02:02 PDT
Comment on attachment 97926 [details] propose a simple patch Clearing flags on attachment: 97926 Committed r89800: <http://trac.webkit.org/changeset/89800>
WebKit Review Bot
Comment 7 2011-06-27 01:02:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.