Bug 63549

Summary: new-run-webkit-tests should not run mthml tests when MHTML suppport is disabled
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, ojan, ossy, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 34984    
Attachments:
Description Flags
Patch none

Eric Seidel (no email)
Reported 2011-06-28 11:28:55 PDT
new-run-webkit-tests should not run mthml tests when MHTML suppport is disabled
Attachments
Patch (4.08 KB, patch)
2011-06-28 11:31 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-06-28 11:31:19 PDT
Created attachment 98950 [details] Patch
Eric Seidel (no email)
Comment 2 2011-06-28 11:38:44 PDT
Just slowly burning down the list of failures on http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28NRWT%29
Tony Chang
Comment 3 2011-06-28 11:45:04 PDT
Comment on attachment 98950 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98950&action=review > Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py:89 > + expected_directories = set(["mathml", "fast/canvas/webgl", "compositing/webgl", "http/tests/canvas/webgl", "fast/wcss", "mhtml"]) Nit: Should we sort these alphabetically?
Eric Seidel (no email)
Comment 4 2011-06-28 11:48:36 PDT
Comment on attachment 98950 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98950&action=review Thanks for the review! >> Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py:89 >> + expected_directories = set(["mathml", "fast/canvas/webgl", "compositing/webgl", "http/tests/canvas/webgl", "fast/wcss", "mhtml"]) > > Nit: Should we sort these alphabetically? I'm not sure it really matters given that they're a set. :)
Tony Chang
Comment 5 2011-06-28 11:55:49 PDT
(In reply to comment #4) > (From update of attachment 98950 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=98950&action=review > > Thanks for the review! > > >> Tools/Scripts/webkitpy/layout_tests/port/webkit_unittest.py:89 > >> + expected_directories = set(["mathml", "fast/canvas/webgl", "compositing/webgl", "http/tests/canvas/webgl", "fast/wcss", "mhtml"]) > > > > Nit: Should we sort these alphabetically? > > I'm not sure it really matters given that they're a set. :) The sorting is to make it easier for humans to read, not the computer :)
WebKit Review Bot
Comment 6 2011-06-28 12:33:40 PDT
Comment on attachment 98950 [details] Patch Clearing flags on attachment: 98950 Committed r89949: <http://trac.webkit.org/changeset/89949>
WebKit Review Bot
Comment 7 2011-06-28 12:33:45 PDT
All reviewed patches have been landed. Closing bug.
Eric Seidel (no email)
Comment 8 2011-06-29 17:18:04 PDT
*** Bug 63523 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.