Bug 63577

Summary:

Switch paintBoxShadow and paintBoxDecorations to new layout types

Product:

WebKit

Reporter:

Levi Weintraub <leviw>

Component:

Layout and Rendering

Assignee:

Levi Weintraub <leviw>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eae, eric, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

63567

Attachments:

Description	Flags
Patch	eric: review+, webkit.review.bot: commit-queue-
Patch for landing	webkit.review.bot: commit-queue-

Levi Weintraub

Reported 2011-06-28 16:12:40 PDT

Ongoing switch to the new abstraction.

Attachments
Patch (21.89 KB, patch) 2011-06-28 16:17 PDT, Levi Weintraub	eric: review+ webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Patch for landing (20.44 KB, patch) 2011-06-28 17:06 PDT, Levi Weintraub	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Levi Weintraub

Comment 1 2011-06-28 16:17:43 PDT

Created attachment 98993 [details] Patch

Levi Weintraub

Comment 2 2011-06-28 16:23:53 PDT

Comment on attachment 98993 [details] Patch Thanks!

WebKit Review Bot

Comment 3 2011-06-28 16:44:30 PDT

Comment on attachment 98993 [details] Patch Rejecting attachment 98993 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 2 Last 500 characters of output: e51e4b99f94b1d391906c90acb27b8de75ee35f3 r89975 = 2f1e2518839b1d4fe70a6d491c6b7f51345bbf09 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Updating chromium port dependencies using gclient... ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/8957043

Levi Weintraub

Comment 4 2011-06-28 17:06:07 PDT

Created attachment 99005 [details] Patch for landing Damn my own conflicts :p

WebKit Review Bot

Comment 5 2011-06-28 17:46:49 PDT

Comment on attachment 99005 [details] Patch for landing Rejecting attachment 99005 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-03', '--port..." exit_code: 1 Last 500 characters of output: ommit-queue/Tools/Scripts/webkitpy/tool/commands/stepsequence.py", line 64, in _run step(tool, options).run(state) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 57, in run if self._has_valid_reviewer(changelog_entry): File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 42, in _has_valid_reviewer if changelog_entry.reviewer(): AttributeError: 'NoneType' object has no attribute 'reviewer' Full output: http://queues.webkit.org/results/8950947

Levi Weintraub

Comment 6 2011-06-28 17:53:10 PDT

Committed r89979: <http://trac.webkit.org/changeset/89979>

Note You need to log in before you can comment on or make changes to this bug.