Bug 63839

Summary: buildbot needs to understand whether NRWT exited early after having too many failures
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, ojan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 34984    
Attachments:
Description Flags
Patch none

WebKit Review Bot
Reported 2011-07-01 13:30:26 PDT
buildbot needs to understand whether NRWT exited early after having too many failures Requested by abarth on #webkit.
Attachments
Patch (19.89 KB, patch)
2011-07-05 15:05 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-07-05 13:23:19 PDT
The results.json needs to include that information too.
Adam Barth
Comment 2 2011-07-05 14:48:33 PDT
> The results.json needs to include that information too. It might already. If not, it's easy to add.
Eric Seidel (no email)
Comment 3 2011-07-05 15:05:24 PDT
Created attachment 99750 [details] Patch
Adam Barth
Comment 4 2011-07-05 15:25:36 PDT
Comment on attachment 99750 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99750&action=review > Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py:212 > + results['interrupted'] = interrupted # Does results.html have enough information to compute this itself? (by checking total number of results vs. total number of tests?) I doubt it. You can restrict the test set in a bunch of different ways.
Ojan Vafai
Comment 5 2011-07-05 15:48:12 PDT
Comment on attachment 99750 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99750&action=review > Tools/ChangeLog:15 > + itself. It's possible Ojan could come up with a better fix. Nope. This is roughly how I would have done it. >> Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py:212 >> + results['interrupted'] = interrupted # Does results.html have enough information to compute this itself? (by checking total number of results vs. total number of tests?) > > I doubt it. You can restrict the test set in a bunch of different ways. Agree.
WebKit Review Bot
Comment 6 2011-07-05 16:16:31 PDT
Comment on attachment 99750 [details] Patch Clearing flags on attachment: 99750 Committed r90413: <http://trac.webkit.org/changeset/90413>
WebKit Review Bot
Comment 7 2011-07-05 16:16:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.