Bug 63970

Summary: new-run-webkit-tests doesn't understand --qt or --gtk
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: WebKit Review Bot <webkit.review.bot>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, eric, mrobinson, ojan, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 64491    
Attachments:
Description Flags
Patch none

WebKit Review Bot
Reported 2011-07-05 20:31:39 PDT
new-run-webkit-tests doesn't understand --qt or --gtk Requested by eseidel2 on #webkit.
Attachments
Patch (5.76 KB, patch)
2011-10-27 14:53 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-07-05 20:36:33 PDT
I've committed a workaround in run-webkit-tests for now: http://trac.webkit.org/changeset/90431
Eric Seidel (no email)
Comment 2 2011-10-24 10:35:39 PDT
Moving this to the polish stage. This has not stopped Qt or Gtk from moving to NRWT.
Eric Seidel (no email)
Comment 3 2011-10-27 14:53:47 PDT
Created attachment 112760 [details] Patch
Eric Seidel (no email)
Comment 4 2011-10-27 14:54:11 PDT
Very easy. :) Clearly I need to spend some time cleaning up our options parsing code.
Ojan Vafai
Comment 5 2011-10-27 15:09:36 PDT
Comment on attachment 112760 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112760&action=review > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:312 > optparse.make_option("--full-results-html", action="store_true", > default=False, > - help="Show all failures in results.html, rather than only " > - "regressions"), > + help="Show all failures in results.html, rather than only regressions"), Not related to this patch, but I *think* this is a misnomer now. I think all this does is that it decides whether we open the results.html page in cases where all the failures are expected (e.g. they're all listed in test_expectations). I guess what it should do is open the results.html page with the show expected failures checkbox checked.
WebKit Review Bot
Comment 6 2011-10-27 17:21:25 PDT
Comment on attachment 112760 [details] Patch Clearing flags on attachment: 112760 Committed r98665: <http://trac.webkit.org/changeset/98665>
WebKit Review Bot
Comment 7 2011-10-27 17:21:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.