Bug 64145

Summary: WebSocket: Clear cookies after test in httponly-cookie.pl
Product: WebKit Reporter: Yuta Kitamura <yutak>
Component: Tools / TestsAssignee: Yuta Kitamura <yutak>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 50099    
Attachments:
Description Flags
Patch
none
Patch v2
none
Patch v3 none

Yuta Kitamura
Reported 2011-07-07 21:15:20 PDT
While I was testing the new protocol implementation, I found that a WebSocket test httponly-cookie.pl leaks cookies, which will cause a test failure after a new set of tests is added under http/tests/websocket/tests.
Attachments
Patch (2.24 KB, patch)
2011-07-07 21:23 PDT, Yuta Kitamura 		no flags
DetailsFormatted DiffDiff
Patch v2 (2.55 KB, patch)
2011-07-07 22:11 PDT, Yuta Kitamura 		no flags
DetailsFormatted DiffDiff
Patch v3 (2.48 KB, patch)
2011-07-07 22:24 PDT, Yuta Kitamura 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yuta Kitamura
Comment 1 2011-07-07 21:23:50 PDT
Created attachment 100068 [details] Patch
Kent Tamura
Comment 2 2011-07-07 21:29:54 PDT
Comment on attachment 100068 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100068&action=review > LayoutTests/ChangeLog:11 > + WebSocket: Clear cookies after test in httponly-cookie.pl > + https://bugs.webkit.org/show_bug.cgi?id=64145 > + > + Reviewed by NOBODY (OOPS!). > + > + * http/tests/websocket/tests/hixie76/httponly-cookie.pl: > + After the test, send an XHR request to itself with a query parameter, > + which erases cookies used in this test. > + Please mention the reason we need to clear cookies.
Yuta Kitamura
Comment 3 2011-07-07 22:11:52 PDT
Created attachment 100069 [details] Patch v2
Yuta Kitamura
Comment 4 2011-07-07 22:13:07 PDT
Comment on attachment 100068 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100068&action=review >> LayoutTests/ChangeLog:11 >> + > > Please mention the reason we need to clear cookies. Fixed in patch v2.
Kent Tamura
Comment 5 2011-07-07 22:20:38 PDT
Comment on attachment 100069 [details] Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=100069&action=review > LayoutTests/ChangeLog:12 > + While I was testing the new protocol implementation, I found that > + this test leaks cookies, which would cause a test failure if we put > + a copy of this test under http/tests/websocket/tests. > + > + To avoid this issue, cookies should be removed before the test ends. Using the word "I" in ChangeLog looks strange. We need objective facts, instead of your experience or viewpoint. So I would like remove "While I was ..., I found that"
Yuta Kitamura
Comment 6 2011-07-07 22:24:16 PDT
Created attachment 100073 [details] Patch v3
Kent Tamura
Comment 7 2011-07-07 22:25:27 PDT
Comment on attachment 100073 [details] Patch v3 ok
WebKit Review Bot
Comment 8 2011-07-07 23:41:40 PDT
Comment on attachment 100073 [details] Patch v3 Clearing flags on attachment: 100073 Committed r90612: <http://trac.webkit.org/changeset/90612>
WebKit Review Bot
Comment 9 2011-07-07 23:41:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.