Bug 65053

Summary: Switching off acceleration for small canvas broke gpu tests
Product: WebKit Reporter: Alok Priyadarshi <alokp>
Component: Layout and RenderingAssignee: Alok Priyadarshi <alokp>
Status: RESOLVED FIXED    
Severity: Normal CC: bsalomon, jamesr, mdelaney7, senorblanco, vangelis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch
none
proposed patch none

Alok Priyadarshi
Reported 2011-07-22 15:41:27 PDT
Test expectations for gpu tests do not match if acceleration is switched off for small canvas. We should disable switching acceleration when testing so that we can have a consistent set of test expectations. This does not alter the test coverage because we already run canvas test for both hardware and software. The tests got broken in: http://trac.webkit.org/changeset/91599
Attachments
proposed patch (7.42 KB, patch)
2011-07-22 15:56 PDT, Alok Priyadarshi 		no flags
DetailsFormatted DiffDiff
proposed patch (9.63 KB, patch)
2011-07-22 16:08 PDT, Alok Priyadarshi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alok Priyadarshi
Comment 1 2011-07-22 15:56:46 PDT
Created attachment 101785 [details] proposed patch
James Robinson
Comment 2 2011-07-22 15:58:26 PDT
Comment on attachment 101785 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=101785&action=review At first glance, I think this is reasonable. I'm curious what others think. > Source/WebCore/page/Settings.h:364 > + // Hardware acceleration is useful for large canvii where it can avoid the nit: i think it's "canvases"
Alok Priyadarshi
Comment 3 2011-07-22 16:08:11 PDT
Created attachment 101786 [details] proposed patch The last patch had missing files. Verified that all canvas-related tests pass with this patch.
Alok Priyadarshi
Comment 4 2011-07-22 16:48:23 PDT
ping! GPU bots are red - this needs to be committed ASAP. BTW there are also some unrelated regressions in GPU tests related to rotated layers and scrollbar rendering.
Brian Salomon
Comment 5 2011-07-22 21:05:03 PDT
I'm not very familiar with how these settings are managed but it looks reasonable.
Stephen White
Comment 6 2011-07-23 06:05:35 PDT
Comment on attachment 101786 [details] proposed patch Looks good. r=me
WebKit Review Bot
Comment 7 2011-07-23 11:45:10 PDT
Comment on attachment 101786 [details] proposed patch Clearing flags on attachment: 101786 Committed r91638: <http://trac.webkit.org/changeset/91638>
WebKit Review Bot
Comment 8 2011-07-23 11:45:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.