Bug 65484

Created attachment 102550 [details] Work in Progress (Mac only) I still need to update the platform GraphicsContext code for other platforms. This is currently passing all tests on Mac.

Comment on attachment 102550 [details] Work in Progress (Mac only) Attachment 102550 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/9285513

Comment on attachment 102550 [details] Work in Progress (Mac only) Attachment 102550 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/9284531

Comment on attachment 102550 [details] Work in Progress (Mac only) Attachment 102550 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9290501

Comment on attachment 102550 [details] Work in Progress (Mac only) View in context: https://bugs.webkit.org/attachment.cgi?id=102550&action=review > Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp:-295 > - if (((int)width) % 2) { > - if (isVerticalLine) { > - // We're a vertical line. Adjust our x. > - p1.move(0.5f, 0.0f); > - p2.move(0.5f, 0.0f); > - } else { > - // We're a horizontal line. Adjust our y. > - p1.move(0.0f, 0.5f); > - p2.move(0.0f, 0.5f); > - } Are there layout tests that used to exercise this code? I'm a bit dubious about removing it in this patch.

(In reply to comment #5) > Are there layout tests that used to exercise this code? I'm a bit dubious about removing it in this patch. Yes there definitely are, namely the css2.1 border box tests. Read why this code is necessary in the comment I also removed. With this patch, WebKit doesn't truncate to integer when dividing by 2, which means we don't have to get that precision back in the platform layer.

Created attachment 102573 [details] Patch

Comment on attachment 102573 [details] Patch Attachment 102573 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/9286529

Comment on attachment 102573 [details] Patch Attachment 102573 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9290531

(In reply to comment #9) > (From update of attachment 102573 [details]) > Attachment 102573 [details] did not pass chromium-ews (chromium-xvfb): > Output: http://queues.webkit.org/results/9290531 Looks like the Win bot is offline, but I'll re-upload build fixes once the rest of the bots process.

Created attachment 102594 [details] Patch

Comment on attachment 102594 [details] Patch Attachment 102594 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/9288591

Comment on attachment 102594 [details] Patch Attachment 102594 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9287543

Created attachment 102682 [details] Build fixes for qt and linux

Comment on attachment 102682 [details] Build fixes for qt and linux Attachment 102682 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/9224069

Comment on attachment 102682 [details] Build fixes for qt and linux Attachment 102682 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9290828

Created attachment 102712 [details] More build fixes

Comment on attachment 102712 [details] More build fixes Attachment 102712 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9300090 New failing tests: css2.1/t170602-bdr-conflct-w-61-d.html css2.1/t170602-bdr-conflct-w-72-d.html css2.1/t170602-bdr-conflct-w-56-d.html css2.1/t170602-bdr-conflct-w-75-d.html css2.1/t170602-bdr-conflct-w-67-d.html css2.1/t0805-c5522-brdr-00-b.html css2.1/t170602-bdr-conflct-w-69-d.html css2.1/t170602-bdr-conflct-w-62-d.html css2.1/t170602-bdr-conflct-w-52-d.html css2.1/t170602-bdr-conflct-w-68-d.html css2.1/t170602-bdr-conflct-w-57-d.html css2.1/t170602-bdr-conflct-w-55-d.html css2.1/t170602-bdr-conflct-w-59-d.html css2.1/t170602-bdr-conflct-w-76-d.html css2.1/t170602-bdr-conflct-w-71-d.html css2.1/t0805-c5517-brdr-s-00-c.html css2.1/t170602-bdr-conflct-w-51-d.html css2.1/t170602-bdr-conflct-w-58-d.html css2.1/t170602-bdr-conflct-w-65-d.html css2.1/t170602-bdr-conflct-w-66-d.html

Created attachment 102722 [details] Archive of layout-test-results from ec2-cr-linux-02 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-02 Port: Chromium Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

Created attachment 102805 [details] Fix for Ciaro, Qt, and Skia line border drawing

Comment on attachment 102805 [details] Fix for Ciaro, Qt, and Skia line border drawing Attachment 102805 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9305064 New failing tests: css2.1/t170602-bdr-conflct-w-61-d.html css2.1/t170602-bdr-conflct-w-72-d.html css2.1/t170602-bdr-conflct-w-56-d.html css2.1/t170602-bdr-conflct-w-75-d.html css2.1/t170602-bdr-conflct-w-67-d.html css2.1/t0805-c5522-brdr-00-b.html css2.1/t170602-bdr-conflct-w-69-d.html css2.1/t170602-bdr-conflct-w-62-d.html css2.1/t170602-bdr-conflct-w-52-d.html css2.1/t170602-bdr-conflct-w-68-d.html css2.1/t170602-bdr-conflct-w-57-d.html css2.1/t170602-bdr-conflct-w-55-d.html css2.1/t170602-bdr-conflct-w-59-d.html css2.1/t170602-bdr-conflct-w-76-d.html css2.1/t170602-bdr-conflct-w-71-d.html css2.1/t0805-c5517-brdr-s-00-c.html css2.1/t170602-bdr-conflct-w-51-d.html css2.1/t170602-bdr-conflct-w-58-d.html css2.1/t170602-bdr-conflct-w-65-d.html css2.1/t170602-bdr-conflct-w-66-d.html

Created attachment 102813 [details] Archive of layout-test-results from ec2-cr-linux-01 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-01 Port: Chromium Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick

Created attachment 104069 [details] Now working on all platforms. May cause a couple very small rendering differences. Will re-request a review pending results from the cr-linux bot.

Comment on attachment 104069 [details] Now working on all platforms. May cause a couple very small rendering differences. Attachment 104069 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/9408231

Comment on attachment 104069 [details] Now working on all platforms. May cause a couple very small rendering differences. Attachment 104069 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/9408233

Comment on attachment 104069 [details] Now working on all platforms. May cause a couple very small rendering differences. Attachment 104069 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9407307

Comment on attachment 104069 [details] Now working on all platforms. May cause a couple very small rendering differences. Attachment 104069 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/9414083

Created attachment 104082 [details] Had missed one local edit, d'oh

Comment on attachment 104082 [details] Had missed one local edit, d'oh Attachment 104082 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9425161 New failing tests: fast/css/background-clip-values.html fast/forms/input-number-events.html media/audio-controls-rendering.html fast/backgrounds/gradient-background-leakage.html fast/transforms/shadows.html fast/borders/borderRadiusDashed02.html fast/layers/video-layer.html fast/backgrounds/repeat/negative-offset-repeat-transformed.html fast/borders/border-radius-constraints.html fast/gradients/background-clipped.html fast/borders/border-radius-huge-assert.html fast/forms/input-spinbutton-capturing.html fast/forms/input-number-large-padding.html css2.1/t0805-c5517-brdr-s-00-c.html fast/borders/borderRadiusDotted01.html fast/forms/implicit-submission.html

Created attachment 104725 [details] Fixes to Path.cpp to properly clip to new roundedRects.

Created attachment 104736 [details] New fixes updated to trunk

Attachment 104736 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/inspector/DOMNodeHighlighte..." exit_code: 1 Source/WebCore/platform/graphics/RoundedRect.cpp:43: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/platform/graphics/RoundedRect.cpp:44: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/platform/graphics/RoundedRect.cpp:49: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/platform/graphics/RoundedRect.cpp:52: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/platform/graphics/RoundedRect.cpp:53: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/platform/graphics/RoundedRect.cpp:54: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/platform/graphics/RoundedRect.cpp:56: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/platform/graphics/RoundedRect.cpp:57: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/platform/graphics/RoundedRect.cpp:59: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/platform/graphics/RoundedRect.cpp:60: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/platform/graphics/RoundedRect.cpp:62: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/platform/graphics/RoundedRect.cpp:63: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 12 in 29 files If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 104736 [details] New fixes updated to trunk Attachment 104736 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/9468877

Created attachment 104761 [details] Build fixes

Attachment 104761 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/inspector/DOMNodeHighlighte..." exit_code: 1 Source/WebCore/platform/graphics/RoundedRect.cpp:43: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/platform/graphics/RoundedRect.cpp:44: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/platform/graphics/RoundedRect.cpp:49: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/platform/graphics/RoundedRect.cpp:52: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/platform/graphics/RoundedRect.cpp:53: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/platform/graphics/RoundedRect.cpp:54: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/platform/graphics/RoundedRect.cpp:56: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/platform/graphics/RoundedRect.cpp:57: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/platform/graphics/RoundedRect.cpp:59: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/platform/graphics/RoundedRect.cpp:60: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/platform/graphics/RoundedRect.cpp:62: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Source/WebCore/platform/graphics/RoundedRect.cpp:63: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 12 in 31 files If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 104761 [details] Build fixes Attachment 104761 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9476180 New failing tests: media/video-no-audio.html media/controls-strict.html media/controls-styling.html media/video-display-toggle.html media/audio-repaint.html media/audio-controls-rendering.html fast/transforms/shadows.html media/video-controls-rendering.html fast/borders/border-radius-constraints.html media/controls-without-preload.html media/media-controls-clone.html fast/layers/video-layer.html media/video-empty-source.html fast/forms/implicit-submission.html media/controls-after-reload.html