Bug 66066

Summary: New expectation entries should be placed next to existing ones.
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: Tools / TestsAssignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 64183    
Attachments:
Description Flags
Patch abarth: review+, webkit.review.bot: commit-queue-

Dimitri Glazkov (Google)
Reported 2011-08-11 09:28:18 PDT
New expectation entries should be placed next to existing ones.
Attachments
Patch (7.45 KB, patch)
2011-08-11 09:29 PDT, Dimitri Glazkov (Google) 		abarth: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2011-08-11 09:29:38 PDT
Created attachment 103636 [details] Patch
WebKit Review Bot
Comment 2 2011-08-11 09:52:18 PDT
Comment on attachment 103636 [details] Patch Rejecting attachment 103636 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-01', '--port..." exit_code: 2 Last 500 characters of output: le Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py patching file Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py Hunk #2 FAILED at 900. 1 out of 3 hunks FAILED -- saving rejects to file Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/9371079
Dimitri Glazkov (Google)
Comment 3 2011-08-11 09:56:36 PDT
Committed r92861: <http://trac.webkit.org/changeset/92861>
Note You need to log in before you can comment on or make changes to this bug.