Bug 67078

Summary: new-run-webkit-tests chromium port fails a windows test in test-webkitpy
Product: WebKit Reporter: Shawn Singh <shawnsingh>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dpranke, eric, levin, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Shawn Singh
Reported 2011-08-26 19:08:40 PDT
Missed one small fix that caused test-webkitpy to fail when testing chromium port of NRWT on windows.
Attachments
Patch (1.26 KB, patch)
2011-08-26 19:16 PDT, Shawn Singh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Shawn Singh
Comment 1 2011-08-26 19:16:20 PDT
Created attachment 105431 [details] Patch
Eric Seidel (no email)
Comment 2 2011-08-29 12:04:26 PDT
Comment on attachment 105431 [details] Patch How do we test this?
Tony Chang
Comment 3 2011-08-29 12:06:21 PDT
Which test is failing? Why doesn't it show up on the the build.webkit.org bots?
Dirk Pranke
Comment 4 2011-08-29 12:10:02 PDT
Comment on attachment 105431 [details] Patch Whoops. The change seems fine to me, but it would be good to answer Tony and Eric's questions, and it would be good to have a test if it wouldn't be too much of a hassle (I haven't thought about what it would take to test this but we can discuss it if you like). Clearing R+/CQ+ for now.
Shawn Singh
Comment 5 2011-08-29 12:29:23 PDT
Right, I should have explained. In my opinion there already is an appropriate test for this patch. It is the unit test code for NWRT itself, which can be run by Tools/Scripts/test-webkitpy. The specific test that was failing is test_diff_image() in Tools/Scripts/webkitpy/layout_tests/port/chromium_unittest.py. This patch fixes a previous fix that I submitted for https://bugs.webkit.org/show_bug.cgi?id=47240 that patch did fail (as it should have) the test-webkitpy script, so I feel the existing tests are appropriate.
Dirk Pranke
Comment 6 2011-08-29 12:46:43 PDT
Comment on attachment 105431 [details] Patch ok.
WebKit Review Bot
Comment 7 2011-08-29 13:17:03 PDT
Comment on attachment 105431 [details] Patch Clearing flags on attachment: 105431 Committed r94008: <http://trac.webkit.org/changeset/94008>
WebKit Review Bot
Comment 8 2011-08-29 13:17:08 PDT
All reviewed patches have been landed. Closing bug.
David Levin
Comment 9 2011-08-29 14:21:19 PDT
Note it is good to mention something about the testing in the ChangeLog. For example, this fixes test_diff_image() from Tools/Scripts/webkitpy/layout_tests/port/chromium_unittest.py. Then it would answer people's questions in the bug and when they see the check in.
Shawn Singh
Comment 10 2011-08-29 14:38:43 PDT
OK, I will do that from now on. Thanks!
Note You need to log in before you can comment on or make changes to this bug.