Bug 67589

Summary: [chromium skia] JPEGImageEncoder: hoist constants out of the encoding loop
Product: WebKit Reporter: noel gordon <noel.gordon>
Component: New BugsAssignee: noel gordon <noel.gordon>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, hbono, jbauman, kbr, senorblanco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 67618    
Bug Blocks: 67402    
Attachments:
Description Flags
Patch
none
Patch fix Mac Chrome compile.
none
Patch for landing. none

noel gordon
Reported 2011-09-05 01:11:49 PDT
Change the row converter function signatures to be identical, call them via a function pointer from the encoding loop.
Attachments
Patch (6.21 KB, patch)
2011-09-05 01:32 PDT, noel gordon 		no flags
DetailsFormatted DiffDiff
Patch fix Mac Chrome compile. (6.22 KB, patch)
2011-09-05 14:30 PDT, noel gordon 		no flags
DetailsFormatted DiffDiff
Patch for landing. (6.12 KB, patch)
2011-09-05 19:40 PDT, noel gordon 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
noel gordon
Comment 1 2011-09-05 01:32:16 PDT
Created attachment 106314 [details] Patch
WebKit Review Bot
Comment 2 2011-09-05 12:55:10 PDT
Comment on attachment 106314 [details] Patch Clearing flags on attachment: 106314 Committed r94537: <http://trac.webkit.org/changeset/94537>
WebKit Review Bot
Comment 3 2011-09-05 12:55:14 PDT
All reviewed patches have been landed. Closing bug.
Adam Barth
Comment 4 2011-09-05 14:04:36 PDT
See the Bug 67618 for the compile error.
noel gordon
Comment 5 2011-09-05 14:29:18 PDT
Thankyou. Skia is being compiled into mac chrome, hmmm ...
noel gordon
Comment 6 2011-09-05 14:30:22 PDT
Created attachment 106359 [details] Patch fix Mac Chrome compile. Not a work yet, will compile on the mac once there.
noel gordon
Comment 7 2011-09-05 19:40:40 PDT
Created attachment 106376 [details] Patch for landing. Chrome mac release+debug compile & test fine for me.
Kenneth Russell
Comment 8 2011-09-06 12:32:23 PDT
Comment on attachment 106376 [details] Patch for landing. Looks OK. Let's try again.
WebKit Review Bot
Comment 9 2011-09-06 12:49:25 PDT
Comment on attachment 106376 [details] Patch for landing. Clearing flags on attachment: 106376 Committed r94591: <http://trac.webkit.org/changeset/94591>
WebKit Review Bot
Comment 10 2011-09-06 12:49:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.