Bug 67685

Summary: Update tests for inherit and initial values for -webkit-columns and related CSS properties.
Product: WebKit Reporter: Luke Macpherson <macpherson>
Component: New BugsAssignee: Luke Macpherson <macpherson>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, eric, levin, macpherson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 67106    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Luke Macpherson
Reported 2011-09-06 16:44:36 PDT
Update tests for inherit and initial values for -webkit-columns and related CSS properties.
Attachments
Patch (27.48 KB, patch)
2011-09-06 16:57 PDT, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
Patch (24.61 KB, patch)
2011-09-06 17:30 PDT, Luke Macpherson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Luke Macpherson
Comment 1 2011-09-06 16:57:46 PDT
Created attachment 106519 [details] Patch
Eric Seidel (no email)
Comment 2 2011-09-06 17:01:24 PDT
Comment on attachment 106519 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106519&action=review > LayoutTests/fast/multicol/initial-column-values-expected.txt:2 > +ALERT: blah > +CONSOLE MESSAGE: line 41: TypeError: 'null' is not an object (evaluating 'document.getElementById("parent").style') Huh?
Luke Macpherson
Comment 3 2011-09-06 17:03:16 PDT
Good point. Let me take a look...
Luke Macpherson
Comment 4 2011-09-06 17:30:13 PDT
Created attachment 106523 [details] Patch
Luke Macpherson
Comment 5 2011-09-06 17:37:17 PDT
Looks like I had somehow uploaded an in-progress copy. Should be better now.
Eric Seidel (no email)
Comment 6 2011-09-06 18:22:29 PDT
Comment on attachment 106523 [details] Patch OK.
WebKit Review Bot
Comment 7 2011-09-08 11:37:20 PDT
Comment on attachment 106523 [details] Patch Clearing flags on attachment: 106523 Committed r94773: <http://trac.webkit.org/changeset/94773>
WebKit Review Bot
Comment 8 2011-09-08 11:37:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.