Bug 68652

Summary: Add ENABLE(CSS_FILTERS)
Product: WebKit Reporter: Dean Jackson <dino>
Component: CSSAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, kbalazs, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 68469    
Attachments:
Description Flags
Patch simon.fraser: review+

Dean Jackson
Reported 2011-09-22 13:23:53 PDT
Add a define for the new filters work.
Attachments
Patch (23.13 KB, patch)
2011-09-22 16:21 PDT, Dean Jackson 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2011-09-22 13:24:44 PDT
<rdar://problem/10170378>
Dean Jackson
Comment 2 2011-09-22 16:21:00 PDT
Created attachment 108417 [details] Patch
Dean Jackson
Comment 3 2011-09-22 17:38:06 PDT
http://trac.webkit.org/changeset/95766
Balazs Kelemen
Comment 4 2011-09-23 02:53:05 PDT
Don't you think it would be better to handle it via Platform.h? This is where such features are handled normally because it is a cleaner way than add logic to every build system. --css-filter need to be handled with an extra define in this case but I think build-webkit is able to set such defines (every platform knows how to transform the set of features to -Dxxx compile switches). I can create the patch if you agree on me.
Dean Jackson
Comment 5 2011-09-23 12:59:34 PDT
(In reply to comment #4) > Don't you think it would be better to handle it via Platform.h? This is where such features are handled normally because it is a cleaner way than add logic to every build system. --css-filter need to be handled with an extra define in this case but I think build-webkit is able to set such defines (every platform knows how to transform the set of features to -Dxxx compile switches). I can create the patch if you agree on me. Can you explain why some features are in Platform.h and others are elsewhere? Platform seems to be for application-level stuff. I couldn't find anything in there that was similar to this feature. All the similar ones are done outside Platform (e.g. the existing ENABLE_FILTER)
Balazs Kelemen
Comment 6 2011-10-03 06:37:49 PDT
(In reply to comment #5) > (In reply to comment #4) > > Don't you think it would be better to handle it via Platform.h? This is where such features are handled normally because it is a cleaner way than add logic to every build system. --css-filter need to be handled with an extra define in this case but I think build-webkit is able to set such defines (every platform knows how to transform the set of features to -Dxxx compile switches). I can create the patch if you agree on me. > > Can you explain why some features are in Platform.h and others are elsewhere? Platform seems to be for application-level stuff. I couldn't find anything in there that was similar to this feature. All the similar ones are done outside Platform (e.g. the existing ENABLE_FILTER) Sorry for letting the topic rot - I was on holiday last week. I have just written a mail to webkit-dev about this.
Note You need to log in before you can comment on or make changes to this bug.