Bug 70104

Summary: [CSS Regions]Change content:-webkit-from-flow to -webkit-flow-from
Product: WebKit Reporter: Mihnea Ovidenie <mihnea>
Component: CSSAssignee: Mihnea Ovidenie <mihnea>
Status: RESOLVED FIXED    
Severity: Normal CC: rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 69752    
Attachments:
Description Flags
Patch
hyatt: review-, hyatt: commit-queue-
Patch 2 none

Mihnea Ovidenie
Reported 2011-10-14 05:45:19 PDT
1. -webkit-flow-from is now a property instead of being an addition to content property. 2. -webkit-flow-from takes an identifier instead of string.
Attachments
Patch (71.11 KB, patch)
2011-10-14 10:30 PDT, Mihnea Ovidenie 		hyatt: review-
hyatt: commit-queue-
DetailsFormatted DiffDiff
Patch 2 (71.49 KB, patch)
2011-10-17 10:17 PDT, Mihnea Ovidenie 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mihnea Ovidenie
Comment 1 2011-10-14 10:30:23 PDT
Created attachment 111028 [details] Patch
Dave Hyatt
Comment 2 2011-10-17 09:14:34 PDT
Comment on attachment 111028 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=111028&action=review > Source/WebCore/css/CSSStyleSelector.cpp:3426 > + if (isInherit) { > + m_style->setRegionThread(nullAtom); > + return; This is wrong. Any reason why you can't just use the composite macro that handles both inherit and initial?
Mihnea Ovidenie
Comment 3 2011-10-17 10:17:01 PDT
Created attachment 111281 [details] Patch 2
WebKit Review Bot
Comment 4 2011-10-17 10:18:41 PDT
Attachment 111281 [details] did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2 Updating OpenSource Current branch master is up to date. Updating chromium port dependencies using gclient... Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107. Re-trying 'depot_tools/gclient sync' No such file or directory at Tools/Scripts/update-webkit line 104. If any of these errors are false positives, please file a bug against check-webkit-style.
Dave Hyatt
Comment 5 2011-10-17 12:14:36 PDT
Comment on attachment 111281 [details] Patch 2 r=me
WebKit Review Bot
Comment 6 2011-10-17 19:16:36 PDT
Comment on attachment 111281 [details] Patch 2 Clearing flags on attachment: 111281 Committed r97701: <http://trac.webkit.org/changeset/97701>
WebKit Review Bot
Comment 7 2011-10-17 19:16:40 PDT
All reviewed patches have been landed. Closing bug.
Ryosuke Niwa
Comment 8 2011-10-17 22:52:16 PDT
This patch appears to have caused 3 printing tests to crash: http://build.webkit.org/results/SnowLeopard%20Intel%20Debug%20(Tests)/r97702%20(2612)/results.html
Mihnea Ovidenie
Comment 9 2011-10-17 23:12:46 PDT
(In reply to comment #8) > This patch appears to have caused 3 printing tests to crash: > http://build.webkit.org/results/SnowLeopard%20Intel%20Debug%20(Tests)/r97702%20(2612)/results.html Taking a look.
Ryosuke Niwa
Comment 10 2011-10-17 23:30:26 PDT
(In reply to comment #9) > (In reply to comment #8) > > This patch appears to have caused 3 printing tests to crash: > > http://build.webkit.org/results/SnowLeopard%20Intel%20Debug%20(Tests)/r97702%20(2612)/results.html > > Taking a look. Oops, this was a false alarm. It's due to r97638.
Mihnea Ovidenie
Comment 11 2011-10-17 23:32:26 PDT
(In reply to comment #10) > (In reply to comment #9) > > (In reply to comment #8) > > > This patch appears to have caused 3 printing tests to crash: > > > http://build.webkit.org/results/SnowLeopard%20Intel%20Debug%20(Tests)/r97702%20(2612)/results.html > > > > Taking a look. > > Oops, this was a false alarm. It's due to r97638. Thanks for sharing the information.
Note You need to log in before you can comment on or make changes to this bug.