Bug 70191

Summary: Rename ENABLE(SKIA_TEXT) to USE(SKIA_TEXT)
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: dbates, eric, jamesr, reed, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 68012    
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing none

Adam Barth
Reported 2011-10-15 18:59:51 PDT
Rename ENABLE(SKIA_TEXT) to USE(SKIA_TEXT)
Attachments
Patch (7.45 KB, patch)
2011-10-15 19:01 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.44 KB, patch)
2011-10-15 20:03 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (7.39 KB, patch)
2011-10-15 21:36 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-10-15 19:01:31 PDT
Created attachment 111162 [details] Patch
Daniel Bates
Comment 2 2011-10-15 19:33:11 PDT
Comment on attachment 111162 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=111162&action=review > Source/WebCore/ChangeLog:8 > + SKIA_TEXT is not a WebKit feature. It's a macro that's determines that's => that > Source/WebCore/ChangeLog:9 > + whether we use a feature of an underly library (Skia). "of an underly" => "of the underlying"
Adam Barth
Comment 3 2011-10-15 20:03:35 PDT
Created attachment 111168 [details] Patch for landing
WebKit Review Bot
Comment 4 2011-10-15 21:26:42 PDT
Comment on attachment 111168 [details] Patch for landing Rejecting attachment 111168 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ore/platform/graphics/skia/SkiaFontWin.cpp patching file Source/WebCore/platform/graphics/skia/SkiaFontWin.h patching file Source/WebKit/chromium/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit/chromium/features.gypi Hunk #1 FAILED at 80. Hunk #2 succeeded at 102 (offset -1 lines). 1 out of 2 hunks FAILED -- saving rejects to file Source/WebKit/chromium/features.gypi.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/10080245
Adam Barth
Comment 5 2011-10-15 21:36:52 PDT
Created attachment 111174 [details] Patch for landing
WebKit Review Bot
Comment 6 2011-10-15 22:58:20 PDT
Comment on attachment 111174 [details] Patch for landing Clearing flags on attachment: 111174 Committed r97573: <http://trac.webkit.org/changeset/97573>
WebKit Review Bot
Comment 7 2011-10-15 22:58:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.