Bug 70267

Summary: CodeGeneratorGObject.pm should use g_value_get_uint() for IDL attributes of type unsigned short.
Product: WebKit Reporter: Anna Cavender <annacc>
Component: WebCore JavaScriptAssignee: Anna Cavender <annacc>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dbates, haraken, japhet, mrobinson, rniwa, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing
none
Patch for landing
none
fix for binding tests dbates: review+, webkit.review.bot: commit-queue-

Anna Cavender
Reported 2011-10-17 13:36:51 PDT
GetGValueTypeName() in CodeGeneratorGObject converts writable attributes of type unsigned short to g_value_get_ushort(), which is a function that does not exist! I propose changing it to instead generate g_value_get_uint(), which does exist, when it sees this type. I think this is a ligit change because GetGValueTypeName() already converts 'short' to 'int', so converting 'unsigned short' to 'uint' seems reasonable. For more info and an example, see https://bugs.webkit.org/show_bug.cgi?id=62887
Attachments
Patch (3.08 KB, patch)
2011-10-17 13:47 PDT, Anna Cavender 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.06 KB, patch)
2011-10-18 09:41 PDT, Anna Cavender 		no flags
DetailsFormatted DiffDiff
Patch for landing (3.06 KB, patch)
2011-10-18 09:46 PDT, Anna Cavender 		no flags
DetailsFormatted DiffDiff
fix for binding tests (1.77 KB, patch)
2011-10-18 12:40 PDT, Anna Cavender 		dbates: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Anna Cavender
Comment 1 2011-10-17 13:47:22 PDT
Created attachment 111315 [details] Patch
WebKit Review Bot
Comment 2 2011-10-17 13:48:50 PDT
Attachment 111315 [details] did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2 Updating OpenSource Current branch master is up to date. Updating chromium port dependencies using gclient... Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107. Re-trying 'depot_tools/gclient sync' No such file or directory at Tools/Scripts/update-webkit line 104. If any of these errors are false positives, please file a bug against check-webkit-style.
Martin Robinson
Comment 3 2011-10-17 23:13:08 PDT
Comment on attachment 111315 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=111315&action=review > Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:1583 > -G_MAXUINT16, /* max */ > +G_MAXUINT, /* max */ Would it make more sense to use G_MAXUSHORT here?
Martin Robinson
Comment 4 2011-10-17 23:13:51 PDT
By the way, thanks for fixing this. I really appreciate it!
Xan Lopez
Comment 5 2011-10-18 01:48:18 PDT
Comment on attachment 111315 [details] Patch This makes sense to me with Martin's suggestion. Thanks for the patch!
Anna Cavender
Comment 6 2011-10-18 09:36:46 PDT
Thanks for the quick review. I'll change to G_MAXUSHORT and then land.
Anna Cavender
Comment 7 2011-10-18 09:41:01 PDT
Created attachment 111454 [details] Patch for landing
WebKit Review Bot
Comment 8 2011-10-18 09:43:54 PDT
Comment on attachment 111454 [details] Patch for landing Rejecting attachment 111454 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 NOBODY (OOPS!) found in /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to committers.py. ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/10124298
Anna Cavender
Comment 9 2011-10-18 09:46:49 PDT
Created attachment 111456 [details] Patch for landing
WebKit Review Bot
Comment 10 2011-10-18 11:17:44 PDT
Comment on attachment 111456 [details] Patch for landing Clearing flags on attachment: 111456 Committed r97778: <http://trac.webkit.org/changeset/97778>
WebKit Review Bot
Comment 11 2011-10-18 11:17:51 PDT
All reviewed patches have been landed. Closing bug.
Ryosuke Niwa
Comment 12 2011-10-18 12:18:43 PDT
It appears that this patch broke binding tests: http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20%28Tests%29/builds/34000
Anna Cavender
Comment 13 2011-10-18 12:31:56 PDT
Oops, looks like G_MAXUINT is required by the test, not G_MAXUSHORT. New patch on the way.
Anna Cavender
Comment 14 2011-10-18 12:40:24 PDT
Created attachment 111482 [details] fix for binding tests
Anna Cavender
Comment 15 2011-10-18 12:56:20 PDT
needs fix for binding tests
WebKit Review Bot
Comment 16 2011-10-18 15:17:45 PDT
Comment on attachment 111482 [details] fix for binding tests Rejecting attachment 111482 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: l Bates', u'--for..." exit_code: 1 Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp Hunk #1 FAILED at 1580. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Daniel Bates', u'--for..." exit_code: 1 Full output: http://queues.webkit.org/results/10142103
Anna Cavender
Comment 17 2011-10-18 15:28:30 PDT
Landed by hand: http://trac.webkit.org/changeset/97793
Note You need to log in before you can comment on or make changes to this bug.