Bug 71007

Summary: [Microdata] Support for itemid attribute.
Product: WebKit Reporter: Arko Saha <arko>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, darin, dglazkov, donggwan.kim, ojan, rniwa, sam, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 68609    
Attachments:
Description Flags
Patch
rniwa: review+
Updated patch
rniwa: review+
Updated patch none

Arko Saha
Reported 2011-10-27 05:18:11 PDT
1. Support for itemid attribute. The itemid attribute specified, to give a global identifier for the Microdata item, so that it can be related to other items on pages elsewhere on the Web. The itemid attribute, if specified, must have a value that is a valid URL potentially surrounded by spaces. Here is the spec : http://www.whatwg.org/specs/web-apps/current-work/multipage/microdata.html#attr-itemid 2. Add test-cases for itemid attribute.
Attachments
Patch (7.22 KB, patch)
2011-10-27 05:30 PDT, Arko Saha 		rniwa: review+
DetailsFormatted DiffDiff
Updated patch (7.21 KB, patch)
2011-10-27 10:09 PDT, Arko Saha 		rniwa: review+
DetailsFormatted DiffDiff
Updated patch (7.95 KB, patch)
2011-10-31 07:29 PDT, Arko Saha 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Arko Saha
Comment 1 2011-10-27 05:30:11 PDT
Created attachment 112666 [details] Patch
Ryosuke Niwa
Comment 2 2011-10-27 08:37:21 PDT
Comment on attachment 112666 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=112666&action=review > Source/WebCore/ChangeLog:8 > + The itemid attribute specified, to give a global identifier for the Microdata item. specified, to give?
Arko Saha
Comment 3 2011-10-27 10:09:49 PDT
Created attachment 112697 [details] Updated patch
Arko Saha
Comment 4 2011-10-31 06:31:34 PDT
Hi Ryosuke, can you please review the patch? Thanks.
Ryosuke Niwa
Comment 5 2011-10-31 06:47:55 PDT
Comment on attachment 112697 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=112697&action=review > LayoutTests/fast/dom/MicroData/itemid-attribute-test-expected.txt:18 > +PASS createElement('div', {itemid: ' http://example.com/foo '}).itemId == 'http://example.com/foo'; is true You should test leading whitespace as well.
Arko Saha
Comment 6 2011-10-31 07:29:15 PDT
Created attachment 113049 [details] Updated patch Incorporating review comments.
WebKit Review Bot
Comment 7 2011-10-31 15:23:05 PDT
Comment on attachment 113049 [details] Updated patch Clearing flags on attachment: 113049 Committed r98888: <http://trac.webkit.org/changeset/98888>
WebKit Review Bot
Comment 8 2011-10-31 15:23:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.