Bug 71238

Summary: Switch RoundedRect back to integers
Product: WebKit Reporter: Levi Weintraub <leviw>
Component: Layout and RenderingAssignee: Levi Weintraub <leviw>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eae, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 63567    
Attachments:
Description Flags
Patch
none
Patch none

Levi Weintraub
Reported 2011-10-31 14:50:49 PDT
Our conversion of RoundedRect to LayoutUnits was premature. As most painting should still be aligned to pixel boundaries, this graphics class should remain int-based.
Attachments
Patch (11.64 KB, patch)
2011-10-31 15:05 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Patch (12.11 KB, patch)
2011-10-31 15:58 PDT, Levi Weintraub 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Levi Weintraub
Comment 1 2011-10-31 15:05:05 PDT
Created attachment 113088 [details] Patch
Early Warning System Bot
Comment 2 2011-10-31 15:17:57 PDT
Comment on attachment 113088 [details] Patch Attachment 113088 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10250065
WebKit Review Bot
Comment 3 2011-10-31 15:36:45 PDT
Comment on attachment 113088 [details] Patch Attachment 113088 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10250071
Levi Weintraub
Comment 4 2011-10-31 15:58:28 PDT
Created attachment 113098 [details] Patch
Darin Adler
Comment 5 2011-10-31 16:03:54 PDT
Comment on attachment 113098 [details] Patch OK.
Levi Weintraub
Comment 6 2011-10-31 16:04:30 PDT
Comment on attachment 113098 [details] Patch Thanks Darin!
WebKit Review Bot
Comment 7 2011-10-31 18:09:19 PDT
Comment on attachment 113098 [details] Patch Clearing flags on attachment: 113098 Committed r98931: <http://trac.webkit.org/changeset/98931>
WebKit Review Bot
Comment 8 2011-10-31 18:09:24 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.