Bug 71364

Summary: CSSStyleRule: Devirtualize selectorText()
Product: WebKit Reporter: Andreas Kling <kling>
Component: CSSAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, macpherson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 34984    
Attachments:
Description Flags
Purposeful patch
koivisto: review+, webkit.review.bot: commit-queue-
Patch for laundry none

Andreas Kling
Reported 2011-11-02 07:17:06 PDT
CSSStyleRule: Devirtualize selectorText()
Attachments
Purposeful patch (2.29 KB, patch)
2011-11-02 07:18 PDT, Andreas Kling 		koivisto: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Patch for laundry (2.80 KB, patch)
2011-11-02 07:41 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2011-11-02 07:18:30 PDT
Created attachment 113314 [details] Purposeful patch
Andreas Kling
Comment 2 2011-11-02 07:19:54 PDT
Comment on attachment 113314 [details] Purposeful patch View in context: https://bugs.webkit.org/attachment.cgi?id=113314&action=review > Source/WebCore/css/CSSStyleRule.cpp:50 > + return static_cast<CSSPageRule*>(this)->selectorText(); should be <const CSSPageRule*>
WebKit Review Bot
Comment 3 2011-11-02 07:22:47 PDT
Comment on attachment 113314 [details] Purposeful patch Attachment 113314 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10190295
Antti Koivisto
Comment 4 2011-11-02 07:23:14 PDT
Comment on attachment 113314 [details] Purposeful patch View in context: https://bugs.webkit.org/attachment.cgi?id=113314&action=review r=me > Source/WebCore/css/CSSStyleRule.cpp:50 > String CSSStyleRule::selectorText() const > { > + if (isPageRule()) > + return static_cast<CSSPageRule*>(this)->selectorText(); It would be less confusing if the subclass function had a different name (pageSelectorText() perhaps?).
Early Warning System Bot
Comment 5 2011-11-02 07:25:28 PDT
Comment on attachment 113314 [details] Purposeful patch Attachment 113314 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10148256
Andreas Kling
Comment 6 2011-11-02 07:41:35 PDT
Created attachment 113317 [details] Patch for laundry
WebKit Review Bot
Comment 7 2011-11-02 08:45:20 PDT
Comment on attachment 113317 [details] Patch for laundry Clearing flags on attachment: 113317 Committed r99063: <http://trac.webkit.org/changeset/99063>
WebKit Review Bot
Comment 8 2011-11-02 08:45:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.