Bug 71792

Created attachment 114030 [details] Patch This won't build on Win.

Attachment 114030 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/editing/spelling/markers.html'..." exit_code: 1 Source/WebCore/testing/Internals.cpp:67: Place brace on its own line for function definitions. [whitespace/braces] [4] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.

Created attachment 114039 [details] Patch

Created attachment 114090 [details] Patch

Created attachment 114183 [details] Patch

Created attachment 114211 [details] Patch

OK, now this patch builds even in Win. It's time to review. morrita-san, could you take a look this?

Comment on attachment 114211 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=114211&action=review > Source/WebCore/testing/Internals.cpp:87 > + Could you propagate error to the caller and throw an exception for this? Ignoring error here will make the troubleshooting hard. Also, I want some way to specify "all". An empty string would be sufficient. > LayoutTests/ChangeLog:10 > + * platform/chromium/test_expectations.txt: Skipped chromium tests. Could you add skip entries for other ports? I guess almost all other port uses test_expectations.txt. Only Apple windows port uses Skipped file.

Created attachment 114276 [details] Patch

(In reply to comment #8) > Could you propagate error to the caller and throw an exception for this? > Ignoring error here will make the troubleshooting hard. > > Also, I want some way to specify "all". An empty string would be sufficient. Done. > > LayoutTests/ChangeLog:10 > > + * platform/chromium/test_expectations.txt: Skipped chromium tests. > > Could you add skip entries for other ports? > I guess almost all other port uses test_expectations.txt. Only Apple windows port uses Skipped file. Skipped all platforms but mac. It seems mac and chromium are using test_expectations.txt, but the other platforms use Skipped file...

Comment on attachment 114276 [details] Patch Attachment 114276 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10365456

Comment on attachment 114276 [details] Patch Attachment 114276 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10370458

Comment on attachment 114276 [details] Patch Attachment 114276 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10399061

Created attachment 114420 [details] Patch

Created attachment 114422 [details] Patch

Attachment 114422 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'LayoutTests/ChangeLog', u'La..." exit_code: 1 Last 3072 characters of output: not exist. svg/as-image/animated-svg-as-image-same-image.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3897: Path does not exist. svg/as-image/animated-svg-as-image-same-image.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3898: Path does not exist. svg/zoom/page/zoom-coords-viewattr-01-b.svg [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3899: Path does not exist. fast/backgrounds/svg-as-mask.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3900: Path does not exist. fast/backgrounds/size/contain-and-cover.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3901: Path does not exist. svg/as-background-image/svg-as-background-5.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3902: Path does not exist. svg/custom/embedding-external-svgs.xhtml [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3904: Path does not exist. svg/as-border-image/svg-as-border-image.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3905: Path does not exist. svg/zoom/page/zoom-img-preserveAspectRatio-support-1.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3906: Path does not exist. svg/as-background-image/svg-as-background-1.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3907: Path does not exist. svg/as-background-image/svg-as-background-3.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3909: Path does not exist. svg/zoom/page/zoom-svg-as-relative-image.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3910: Path does not exist. svg/zoom/page/relative-sized-document-scrollbars.svg [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3912: Path does not exist. storage/indexeddb/key-type-array.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3914: Path does not exist. fast/js/array-functions-non-arrays.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3915: Path does not exist. fast/js/eval-cross-window.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3916: Path does not exist. fast/js/regexp-caching.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3917: Path does not exist. fast/js/toString-overrides.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3918: Path does not exist. fast/js/toString-recursion.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3919: Path does not exist. http/tests/security/xss-eval.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3921: Path does not exist. fast/dom/rtl-scroll-to-leftmost-and-resize.html [test/expectations] [2] Total errors found: 2166 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 114422 [details] Patch The style error looks an intermittent trouble on the bot. Let's land it and see what happens.

Comment on attachment 114422 [details] Patch Clearing flags on attachment: 114422 Committed r99814: <http://trac.webkit.org/changeset/99814>

All reviewed patches have been landed. Closing bug.

Why there's no markers-expected.txt? Also this test isn't skipped on Mac.

editing/spelling/markers.html is still missing the result on Mac. Could you either skip the test or add an appropriate expectation? It's not great to leave a test with missing result in the tree for such a long time.

Oops, sorry, I didn't notice this... I'll work it soon. (In reply to comment #21) > editing/spelling/markers.html is still missing the result on Mac. Could you either skip the test or add an appropriate expectation? It's not great to leave a test with missing result in the tree for such a long time.

Created attachment 116694 [details] Patch

This test appears to be missing results for Lion/mac.

Chromium bots are failing to produce the expected results for editing/spelling/markers.html. I have added FAIL to the test_expectations.txt. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&showLargeExpectations=true&tests=editing%2Fspelling%2Fmarkers.html """ Grammar Error Only PASS internals.markerCountForNode(e.firstChild, "spelling") is 0 FAIL internals.markerCountForNode(e.firstChild, "grammar") should be 1. Was 0. FAIL range.toString() should be a. Threw exception TypeError: Cannot call method 'toString' of null Spelling Error Only PASS internals.markerCountForNode(e.firstChild, "spelling") is 1 PASS range.toString() is "zz" PASS internals.markerCountForNode(e.firstChild, "grammar") is 0 Grammar and Spelling Error PASS internals.markerCountForNode(e.firstChild, "spelling") is 1 PASS range.toString() is "zz" FAIL internals.markerCountForNode(e.firstChild, "grammar") should be 1. Was 0. FAIL range.toString() should be orange,zz,apple.. Threw exception TypeError: Cannot call method 'toString' of null PASS successfullyParsed is true TEST COMPLETE I have a issue. zz. orange,zz,apple. """