Bug 73451

Summary: [NRWT] It crashes intermittently when there are WebProcess crashes
Product: WebKit Reporter: János Badics <jbadics>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, eric, kkristof, ojan, ossy, tony, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 64491    
Attachments:
Description Flags
crash log
none
proposed patch
ossy: review-
proposed patch none

János Badics
Reported 2011-11-30 08:28:58 PST
In some uncertain cases worker0 stops with exception; self._proc is probably None (maybe reseted) or isn't even created.
Attachments
crash log (40.32 KB, text/plain)
2011-11-30 08:30 PST, János Badics 		no flags
Details
proposed patch (1.25 KB, patch)
2011-12-12 03:31 PST, János Badics 		ossy: review-
DetailsFormatted DiffDiff
proposed patch (1.32 KB, patch)
2011-12-13 03:52 PST, János Badics 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
János Badics
Comment 1 2011-11-30 08:30:18 PST
Created attachment 117198 [details] crash log
Csaba Osztrogonác
Comment 2 2011-11-30 08:33:06 PST
Comment on attachment 117198 [details] crash log It isn't patch, so we don't need r? and cq? :)
Csaba Osztrogonác
Comment 3 2011-11-30 08:36:07 PST
Guys, have you got any idea what is this bug? Unfortunately it is too hard to reproduce. :(
Eric Seidel (no email)
Comment 4 2011-11-30 10:59:48 PST
Looks like a design error. _reset() can clear self._proc. _check_for_crash grabs at self._proc w/o checking if it's None or if self.crashed in many places. We just need to re-work that to never be the case.
Csaba Osztrogonác
Comment 5 2011-12-01 02:49:57 PST
*** Bug 73299 has been marked as a duplicate of this bug. ***
Csaba Osztrogonác
Comment 6 2011-12-06 05:24:37 PST
(In reply to comment #4) > Looks like a design error. > > _reset() can clear self._proc. _check_for_crash grabs at self._proc w/o checking if it's None or if self.crashed in many places. We just need to re-work that to never be the case. Do you mean we should use self.poll() instead of self._proc.poll() everywhere? def poll(self): """Check to see if the underlying process is running; returns None if it still is (wrapper around subprocess.poll).""" if self._proc: return self._proc.poll() return None
János Badics
Comment 7 2011-12-12 03:31:32 PST
Created attachment 118765 [details] proposed patch Use self.poll() instead of self._proc.poll() because it checks if self._proc is None or not.
Csaba Osztrogonác
Comment 8 2011-12-12 09:06:55 PST
Comment on attachment 118765 [details] proposed patch r- now, because this patch isn't up-to-date. Could you update your patch to ToT and resubmit?
János Badics
Comment 9 2011-12-13 03:52:24 PST
Created attachment 118996 [details] proposed patch Use self.poll() instead of self._proc.poll() because it checks if self._proc is None or not.
WebKit Review Bot
Comment 10 2011-12-13 05:41:51 PST
Comment on attachment 118996 [details] proposed patch Clearing flags on attachment: 118996 Committed r102677: <http://trac.webkit.org/changeset/102677>
WebKit Review Bot
Comment 11 2011-12-13 05:41:56 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.