Bug 74764

Summary: Make WebIntentServiceInfo constructor public for testing.
Product: WebKit Reporter: Greg Billock <gbillock>
Component: New BugsAssignee: Greg Billock <gbillock>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, fishd, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 75123    
Attachments:
Description Flags
Patch
none
Patch none

Greg Billock
Reported 2011-12-16 16:13:27 PST
Make WebIntentServiceInfo constructor public for testing.
Attachments
Patch (1.52 KB, patch)
2011-12-16 16:13 PST, Greg Billock 		no flags
DetailsFormatted DiffDiff
Patch (2.00 KB, patch)
2011-12-19 09:41 PST, Greg Billock 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Greg Billock
Comment 1 2011-12-16 16:13:52 PST
Created attachment 119694 [details] Patch
WebKit Review Bot
Comment 2 2011-12-16 16:15:25 PST
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Darin Fisher (:fishd, Google)
Comment 3 2011-12-16 16:21:58 PST
Comment on attachment 119694 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119694&action=review > Source/WebKit/chromium/public/WebIntentServiceInfo.h:44 > + WebIntentServiceInfo(); please note that using this constructor will break the build if used outside of webkit.dll. perhaps you mean to export it? WEBKIT_EXPORT is the way, or in this case, I think it would be better to just inline the constructor as we do elsewhere.
WebKit Review Bot
Comment 4 2011-12-16 17:31:47 PST
Comment on attachment 119694 [details] Patch Attachment 119694 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10904943 New failing tests: http/tests/inspector/resource-tree/resource-tree-document-url.html
Greg Billock
Comment 5 2011-12-19 09:41:01 PST
Created attachment 119873 [details] Patch
Greg Billock
Comment 6 2011-12-19 09:50:22 PST
Comment on attachment 119694 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=119694&action=review >> Source/WebKit/chromium/public/WebIntentServiceInfo.h:44 >> + WebIntentServiceInfo(); > > please note that using this constructor will break the build if used outside of > webkit.dll. perhaps you mean to export it? WEBKIT_EXPORT is the way, or in > this case, I think it would be better to just inline the constructor as we do > elsewhere. Done.
WebKit Review Bot
Comment 7 2011-12-20 01:41:47 PST
Comment on attachment 119873 [details] Patch Clearing flags on attachment: 119873 Committed r103311: <http://trac.webkit.org/changeset/103311>
WebKit Review Bot
Comment 8 2011-12-20 01:41:57 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.