Bug 75275
| Summary: | Remove verbose JS*.h and JS*.cpp from GNUmakefile.list.am | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Kentaro Hara <haraken> |
| Component: | WebKitGTK | Assignee: | Zan Dobersek <zan> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | abarth, mrobinson, zan |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 72138 | ||
Kentaro Hara
After r103729, GNUmakefile.list.am contains JS*.h, JS*.cpp and *.idl, like this:
webcore_built_sources += \
DerivedSources/WebCore/JSA.cpp \
DerivedSources/WebCore/JSA.h \
DerivedSources/WebCore/JSB.cpp \
DerivedSources/WebCore/JSB.h \
DerivedSources/WebCore/JSC.cpp \
DerivedSources/WebCore/JSC.h \
....
dom_binding_idls += \
WebCore/aaa/A.idl \
WebCore/bbb/B.idl \
WebCore/ccc/C.idl \
....
This is verbose, and we should remove JS*.h and JS*.cpp as follows:
dom_binding_idls += \
WebCore/aaa/A.idl \
WebCore/bbb/B.idl \
WebCore/ccc/C.idl \
....
webcore_built_sources += $(patsubst %, DerivedSources/WebCore/JS%.cpp, $(basename $(notdir $(dom_binding_idls))))
webcore_built_sources += $(patsubst %, DerivedSources/WebCore/JS%.h, $(basename $(notdir $(dom_binding_idls))))
See the comment #14 in bug 74972 for more details.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Zan Dobersek
That's a really neat idea.
I don't think Kentaro still has any plans to work on this, so I'll look into it.
Martin Robinson
Autotools build is gone now.