Bug 75519

Summary: [GTK] [AC] Introduce AcceleratedCompositingContext to isolate different accelerated compositing implementations
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 74087    
Attachments:
Description Flags
Patch alex: review+

Martin Robinson
Reported 2012-01-03 21:17:35 PST
This class will isolate each of the implementations, hopefully preventing code conflicts as we post patches for acceleated compositing.
Attachments
Patch (15.75 KB, patch)
2012-01-03 22:09 PST, Martin Robinson 		alex: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2012-01-03 22:09:28 PST
Created attachment 121064 [details] Patch
Alejandro G. Castro
Comment 2 2012-01-05 05:45:23 PST
Comment on attachment 121064 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=121064&action=review Great patch. > Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContext.h:34 > +class TextureMapper; > +class TextureMapperNode; Should this be avoided in case of clutter compilation? > Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextClutter.cpp:87 > + if (rect == IntRect()) > + m_rootGraphicsLayer->setNeedsDisplay(); Shouln't we return in this clause to avoid the next setNeedsDisplay with emtpy rect? Are we testing if rect.isEmpty()?
Martin Robinson
Comment 3 2012-01-05 12:17:46 PST
(In reply to comment #2) > (From update of attachment 121064 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=121064&action=review > > Great patch. > > > Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContext.h:34 > > +class TextureMapper; > > +class TextureMapperNode; > > Should this be avoided in case of clutter compilation? Yep! This was left over from my work with TextureMapperGL. I've removed it. > > Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextClutter.cpp:87 > > + if (rect == IntRect()) > > + m_rootGraphicsLayer->setNeedsDisplay(); > > Shouln't we return in this clause to avoid the next setNeedsDisplay with emtpy rect? Are we testing if rect.isEmpty()? Right again on both counts. I've changed the test to rect.isEmpty() and added an early return. Thanks for the review!
Martin Robinson
Comment 4 2012-01-05 12:19:14 PST
Committed r104194: <http://trac.webkit.org/changeset/104194>
Note You need to log in before you can comment on or make changes to this bug.