Bug 76023

Summary: Update and show ewk_view with updated webpage.
Product: WebKit Reporter: Eunmi Lee <enmi.lee>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ryuan.choi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 61838    
Attachments:
Description Flags
patch to update and show ewk_view.
none
patch to update and show ewk_view.
none
patch to update and show ewk_view. none

Eunmi Lee
Reported 2012-01-10 21:04:24 PST
Update ewk_view with BackingStore image which is updated with shareableBitmap from WebProcess, and show updated image's area when PageClientImpl::setViewNeedsDisplay() is called.
Attachments
patch to update and show ewk_view. (5.89 KB, patch)
2012-01-10 21:46 PST, Eunmi Lee 		no flags
DetailsFormatted DiffDiff
patch to update and show ewk_view. (5.87 KB, patch)
2012-01-11 19:00 PST, Eunmi Lee 		no flags
DetailsFormatted DiffDiff
patch to update and show ewk_view. (5.80 KB, patch)
2012-01-12 00:43 PST, Eunmi Lee 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Eunmi Lee
Comment 1 2012-01-10 21:46:13 PST
Created attachment 121972 [details] patch to update and show ewk_view.
Ryuan Choi
Comment 2 2012-01-11 18:33:36 PST
Comment on attachment 121972 [details] patch to update and show ewk_view. View in context: https://bugs.webkit.org/attachment.cgi?id=121972&action=review > Source/WebKit2/UIProcess/API/efl/PageClientImpl.cpp:60 > - evas_object_image_data_update_add(m_viewObject, rect.x(), rect.y(), rect.width(), rect.height()); > + ewk_view_display(m_viewObject, rect); Patch itself is good, but you should rebase this because m_viewObject is renamed. > Source/WebKit2/UIProcess/API/efl/ewk_private.h:32 > +Eina_Bool ewk_view_display(Evas_Object* ewkView, const WebCore::IntRect& rect); > +Eina_Bool ewk_view_image_data_set(Evas_Object* ewkView, void* imageData, const WebCore::IntSize& size); Should we return Eina_Bool?
Eunmi Lee
Comment 3 2012-01-11 19:00:15 PST
Created attachment 122153 [details] patch to update and show ewk_view. Rebase and change Eina_Bool to bool.
Eunmi Lee
Comment 4 2012-01-11 19:01:56 PST
Thanks for your comments :) (In reply to comment #2) > (From update of attachment 121972 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=121972&action=review > > > Source/WebKit2/UIProcess/API/efl/PageClientImpl.cpp:60 > > - evas_object_image_data_update_add(m_viewObject, rect.x(), rect.y(), rect.width(), rect.height()); > > + ewk_view_display(m_viewObject, rect); > > Patch itself is good, but you should rebase this because m_viewObject is renamed. => Rebased. > > > Source/WebKit2/UIProcess/API/efl/ewk_private.h:32 > > +Eina_Bool ewk_view_display(Evas_Object* ewkView, const WebCore::IntRect& rect); > > +Eina_Bool ewk_view_image_data_set(Evas_Object* ewkView, void* imageData, const WebCore::IntSize& size); > > Should we return Eina_Bool? => No, because those APIs are internal private API. so, I've changed Eina_Bool to bool type.
Ryuan Choi
Comment 5 2012-01-11 23:47:05 PST
> > > Source/WebKit2/UIProcess/API/efl/ewk_private.h:32 > > > +Eina_Bool ewk_view_display(Evas_Object* ewkView, const WebCore::IntRect& rect); > > > +Eina_Bool ewk_view_image_data_set(Evas_Object* ewkView, void* imageData, const WebCore::IntSize& size); > > > > Should we return Eina_Bool? > => No, because those APIs are internal private API. so, I've changed Eina_Bool to bool type. IMO, void looks enough.
Eunmi Lee
Comment 6 2012-01-11 23:53:58 PST
(In reply to comment #5) > > > > Source/WebKit2/UIProcess/API/efl/ewk_private.h:32 > > > > +Eina_Bool ewk_view_display(Evas_Object* ewkView, const WebCore::IntRect& rect); > > > > +Eina_Bool ewk_view_image_data_set(Evas_Object* ewkView, void* imageData, const WebCore::IntSize& size); > > > > > > Should we return Eina_Bool? > > => No, because those APIs are internal private API. so, I've changed Eina_Bool to bool type. > > IMO, void looks enough. => I thought you mean to remove "Eina" type. I understand now and I agree with you that boolean return type is not necessary. So, I will change return type from bool to void :)
Eunmi Lee
Comment 7 2012-01-12 00:43:41 PST
Created attachment 122182 [details] patch to update and show ewk_view. Change return type from bool to void.
Ryuan Choi
Comment 8 2012-01-12 00:49:10 PST
(In reply to comment #7) > Created an attachment (id=122182) [details] > patch to update and show ewk_view. > > Change return type from bool to void. Looks good to me.
WebKit Review Bot
Comment 9 2012-01-12 03:10:44 PST
Comment on attachment 122182 [details] patch to update and show ewk_view. Clearing flags on attachment: 122182 Committed r104804: <http://trac.webkit.org/changeset/104804>
WebKit Review Bot
Comment 10 2012-01-12 03:10:48 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.