Bug 76030

Summary: ShouldSkipTypeHeader() and ShouldSkipTypeInImplementation() in CodeGeneratorCPP.pm should be the same
Product: WebKit Reporter: Kentaro Hara <haraken>
Component: WebCore JavaScriptAssignee: Kentaro Hara <haraken>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, darin, japhet, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 72138    
Attachments:
Description Flags
Patch none

Kentaro Hara
Reported 2012-01-10 22:53:22 PST
The conditions under which 1 is returned by ShouldSkipTypeHeader() and ShouldSkipTypeInImplementation() are messy. We should clean up the conditions. This is a refactoring for implementing the [Supplemental] IDL for custom methods.
Attachments
Patch (6.54 KB, patch)
2012-01-10 23:25 PST, Kentaro Hara 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kentaro Hara
Comment 1 2012-01-10 23:25:58 PST
Created attachment 121982 [details] Patch
WebKit Review Bot
Comment 2 2012-01-11 02:25:09 PST
Comment on attachment 121982 [details] Patch Clearing flags on attachment: 121982 Committed r104690: <http://trac.webkit.org/changeset/104690>
WebKit Review Bot
Comment 3 2012-01-11 02:25:19 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.