Bug 76288

Summary: GCC compiler version is not detected properly for QNX qcc variant
Product: WebKit Reporter: Eli Fidler <efidler>
Component: Tools / TestsAssignee: Eli Fidler <efidler>
Status: RESOLVED FIXED    
Severity: Normal CC: leandro, rakuco, rwlbuis, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 73144    
Attachments:
Description Flags
Patch
none
Patch none

Eli Fidler
Reported 2012-01-13 10:47:09 PST
QNX is built with the qcc variant of GCC, which doesn't support -dumpversion.
Attachments
Patch (1.82 KB, patch)
2012-01-13 10:56 PST, Eli Fidler 		no flags
DetailsFormatted DiffDiff
Patch (1.83 KB, patch)
2012-01-13 13:42 PST, Eli Fidler 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eli Fidler
Comment 1 2012-01-13 10:56:22 PST
Created attachment 122460 [details] Patch
Leandro Pereira
Comment 2 2012-01-13 11:30:26 PST
Comment on attachment 122460 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122460&action=review > Source/cmake/WebKitHelpers.cmake:15 > + EXEC_PROGRAM("${CMAKE_CXX_COMPILER} -E -Wp,-dM - < /dev/null | grep __VERSION__ | sed -e 's/^[^\"]*\"//' -e 's/\".*$//'" OUTPUT_VARIABLE COMPILER_VERSION) Nice trick. I'd grep for '^#define __VERSION__ ', in the event that '__VERSION__' is present in some other predefined macro. Also, since this part of the code is just interested in the compiler version numbers anyway, I'd use the more readable "grep -E -o '[0-9]+\.[0-9]+\.?[0-9]+?'" instead of that sed command. This have the added benefit of detecting gcc version as "4.6.2" even if the returned string is "4.6.2 20111223 (prerelease)" (or similar), which is important here as this is used to enable/disable flags to workaround compiler bugs.
Eli Fidler
Comment 3 2012-01-13 13:42:54 PST
Created attachment 122491 [details] Patch
Rob Buis
Comment 4 2012-01-13 14:39:19 PST
Comment on attachment 122491 [details] Patch LGTM.
WebKit Review Bot
Comment 5 2012-01-13 18:47:43 PST
Comment on attachment 122491 [details] Patch Clearing flags on attachment: 122491 Committed r105014: <http://trac.webkit.org/changeset/105014>
WebKit Review Bot
Comment 6 2012-01-13 18:47:47 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.