Bug 77385

Summary: flex-pack:center and flex-item-align:center should do true centering
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: Layout and RenderingAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: hyatt, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 62048    
Attachments:
Description Flags
Patch tony: review+

Attachments
Patch (13.39 KB, patch)
2012-02-10 12:21 PST, Ojan Vafai 		tony: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2012-02-10 12:21:33 PST
Created attachment 126552 [details] Patch
Tony Chang
Comment 2 2012-02-10 12:31:10 PST
Comment on attachment 126552 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=126552&action=review If you wanted to be thorough, you could add writing mode tests. > Source/WebCore/ChangeLog:9 > + Also, removed passing totalPositiveFlexibility around. We don't > + need to know about positive/negative flex once we run the flexing algorithm. I remember why we had this. It was when you could flex margins. Maybe mention that in the ChangeLog.
Ojan Vafai
Comment 3 2012-02-10 15:01:52 PST
Committed r107446: <http://trac.webkit.org/changeset/107446>
Note You need to log in before you can comment on or make changes to this bug.