Bug 77612

Summary: Stop calling Element::ensureShadowRoot in Internals.
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: DOMAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo.noronha, gustavo, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 77608    
Attachments:
Description Flags
Test For Building
none
Patch
none
Patch
none
Patch none

Shinya Kawanaka
Reported 2012-02-02 00:35:03 PST
We want to remove Element::ensureShadowRoot. Let's try to stop calling Element::ensureShadowRoot in Internals first, because changing Internals often causes build error.
Attachments
Test For Building (1.33 KB, patch)
2012-02-02 00:38 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (5.87 KB, patch)
2012-02-02 18:38 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (5.87 KB, patch)
2012-02-02 20:54 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (6.15 KB, patch)
2012-02-02 22:35 PST, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2012-02-02 00:38:44 PST
Created attachment 125092 [details] Test For Building
Collabora GTK+ EWS bot
Comment 2 2012-02-02 09:47:10 PST
Comment on attachment 125092 [details] Test For Building Attachment 125092 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11396858
Shinya Kawanaka
Comment 3 2012-02-02 18:38:56 PST
Created attachment 125230 [details] Patch
Gustavo Noronha (kov)
Comment 4 2012-02-02 20:28:17 PST
Comment on attachment 125230 [details] Patch Attachment 125230 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/11424020
Shinya Kawanaka
Comment 5 2012-02-02 20:54:00 PST
Created attachment 125251 [details] Patch
Hajime Morrita
Comment 6 2012-02-02 21:17:17 PST
Comment on attachment 125251 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=125251&action=review > Source/WebCore/ChangeLog:8 > + Instead of ensureShadowRoot, we check the existence of shadow root and create one if there is not. Could you explain why we need this change? > Source/WebCore/testing/Internals.cpp:199 > + return ShadowRoot::create(host, ec).get(); This is actually safe. But its safety isn't obvious at a glance. Could you change the return type to RefPtr, to make this clearly safe?
Shinya Kawanaka
Comment 7 2012-02-02 22:30:36 PST
> > Source/WebCore/testing/Internals.cpp:199 > > + return ShadowRoot::create(host, ec).get(); > > This is actually safe. But its safety isn't obvious at a glance. > Could you change the return type to RefPtr, to make this clearly safe? Changing PassRefPtr breaks tests actually. So let me leave this as is.
Shinya Kawanaka
Comment 8 2012-02-02 22:35:38 PST
Created attachment 125262 [details] Patch
Hajime Morrita
Comment 9 2012-02-02 22:49:31 PST
Comment on attachment 125262 [details] Patch > Changing PassRefPtr breaks tests actually. > So let me leave this as is. Wow.
WebKit Review Bot
Comment 10 2012-02-03 00:16:47 PST
Comment on attachment 125262 [details] Patch Clearing flags on attachment: 125262 Committed r106635: <http://trac.webkit.org/changeset/106635>
WebKit Review Bot
Comment 11 2012-02-03 00:16:52 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.