Bug 78660

Summary: [BlackBerry] Upstream WebPageClient.h
Product: WebKit Reporter: Leo Yang <leo.yang>
Component: New BugsAssignee: Leo Yang <leo.yang>
Status: RESOLVED FIXED    
Severity: Normal CC: charles.wei, rwlbuis, staikos, tonikitoo, webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 73144    
Attachments:
Description Flags
Patch
rwlbuis: review-
Patch v2
none
Patch v3 tonikitoo: review+

Leo Yang
Reported 2012-02-14 18:52:12 PST
WebKit/blackberry/Api/WebPageClient.h is an interface between the client of a WebPage and the WebPage it self.
Attachments
Patch (14.89 KB, patch)
2012-02-14 19:02 PST, Leo Yang 		rwlbuis: review-
DetailsFormatted DiffDiff
Patch v2 (18.28 KB, patch)
2012-02-14 22:25 PST, Leo Yang 		no flags
DetailsFormatted DiffDiff
Patch v3 (18.28 KB, patch)
2012-02-14 22:30 PST, Leo Yang 		tonikitoo: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Leo Yang
Comment 1 2012-02-14 19:02:39 PST
Created attachment 127101 [details] Patch
Rob Buis
Comment 2 2012-02-14 19:17:28 PST
Comment on attachment 127101 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127101&action=review Looks good, but still some things to fix. > Source/WebKit/blackberry/Api/WebPageClient.h:32 > +#include <BlackBerryPlatformWindow.h> Are all of the above needed? > Source/WebKit/blackberry/Api/WebPageClient.h:34 > +#include <pthread.h> Does not seem needed? > Source/WebKit/blackberry/Api/WebPageClient.h:45 > +class GeoTracker; Not needed?
Leo Yang
Comment 3 2012-02-14 22:25:17 PST
Created attachment 127115 [details] Patch v2 Cleanup some unnecessary header inclusion.
Leo Yang
Comment 4 2012-02-14 22:30:00 PST
Created attachment 127116 [details] Patch v3
WebKit Review Bot
Comment 5 2012-02-15 03:42:17 PST
Attachment 127115 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/plugins/blackberry/PluginViewPrivateBlackBerry.h:25: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 1 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Leo Yang
Comment 6 2012-02-15 18:02:54 PST
Committed r107863: <http://trac.webkit.org/changeset/107863>
Note You need to log in before you can comment on or make changes to this bug.