Bug 78706

Summary: Renaming parameters for positioning a track cue
Product: WebKit Reporter: Victor Carbune <vcarbune>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 43668    
Attachments:
Description Flags
Proposed patch none

Victor Carbune
Reported 2012-02-15 05:37:34 PST
The positioning and size parameters (formerly D:, L:, T:, S:, A:) in the WebVTT spec have been renamed (vertical:, line:, position:, size:, align:) The TextTrackCue::parseSettings method needs to be updated.
Attachments
Proposed patch (65.07 KB, patch)
2012-02-29 18:00 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2012-02-29 15:39:28 PST
<rdar://problem/10958447>
Eric Carlson
Comment 2 2012-02-29 18:00:34 PST
Created attachment 129568 [details] Proposed patch
Sam Weinig
Comment 3 2012-04-02 09:24:07 PDT
Comment on attachment 129568 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=129568&action=review > Source/WebCore/html/track/TextTrackCue.cpp:401 > +TextTrackCue::CueSetting TextTrackCue::settingName(const String& name) > +{ > + DEFINE_STATIC_LOCAL(const String, verticalKeyword, ("vertical")); > + DEFINE_STATIC_LOCAL(const String, lineKeyword, ("line")); > + DEFINE_STATIC_LOCAL(const String, positionKeyword, ("position")); > + DEFINE_STATIC_LOCAL(const String, sizeKeyword, ("size")); > + DEFINE_STATIC_LOCAL(const String, alignKeyword, ("align")); > + > + if (name == verticalKeyword) > + return Vertical; > + else if (name == lineKeyword) > + return Line; > + else if (name == positionKeyword) > + return Position; > + else if (name == sizeKeyword) > + return Size; > + else if (name == alignKeyword) > + return Align; > + > + return None; > +} Is this common enough that we should consider using AtomicString?
WebKit Review Bot
Comment 4 2012-04-02 10:10:53 PDT
Comment on attachment 129568 [details] Proposed patch Clearing flags on attachment: 129568 Committed r112898: <http://trac.webkit.org/changeset/112898>
WebKit Review Bot
Comment 5 2012-04-02 10:10:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.