Bug 79521

Summary: [Qt][WK2] Use movementStarted/Ended signals instead of movingChanged on QtViewportInterationEngine
Product: WebKit Reporter: Hugo Parente Lima <hugo.lima>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: kenneth, menard, webkit.review.bot, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Hugo Parente Lima
Reported 2012-02-24 12:43:45 PST
The movingChanged() signal from Flickable QML component is emitted many times but the QtViewportInteractionEngine is only interested about when the pan starts and when it ends, the Flickable also provide signals for that, so would be better to use those signals (movementStarted()/movementEnded()) instead of movingChanged().
Attachments
Patch (5.81 KB, patch)
2012-02-24 12:49 PST, Hugo Parente Lima 		no flags
DetailsFormatted DiffDiff
Patch (6.38 KB, patch)
2012-02-27 09:52 PST, Hugo Parente Lima 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hugo Parente Lima
Comment 1 2012-02-24 12:49:18 PST
Created attachment 128787 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2012-02-25 05:13:50 PST
Comment on attachment 128787 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=128787&action=review Almost there! > Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp:129 > + connect(m_flickProvider, SIGNAL(movementStarted()), SLOT(panMoveStarted()), Qt::DirectConnection); > + connect(m_flickProvider, SIGNAL(movementEnded()), SLOT(panMoveEnded()), Qt::DirectConnection); I think we should rename those methods to flickableMoveStarted/Ended > Source/WebKit2/UIProcess/qt/QtViewportInteractionEngine.cpp:-193 > - if (m_flickProvider->isMoving()) { > - if (m_scrollUpdateDeferrer) Can be please assert for this inside the panMoveStarted/Ended to ensure that the state is always correct?
Hugo Parente Lima
Comment 3 2012-02-27 09:03:08 PST
Sir, yes sir!
Hugo Parente Lima
Comment 4 2012-02-27 09:52:33 PST
Created attachment 129056 [details] Patch Assertions added, slots renamed.
WebKit Review Bot
Comment 5 2012-02-28 02:40:17 PST
The commit-queue encountered the following flaky tests while processing attachment 129056 [details]: css3/filters/effect-contrast-hw.html bug 79618 (author: cmarrin@apple.com) The commit-queue is continuing to process your patch.
WebKit Review Bot
Comment 6 2012-02-28 02:42:20 PST
Comment on attachment 129056 [details] Patch Clearing flags on attachment: 129056 Committed r109094: <http://trac.webkit.org/changeset/109094>
WebKit Review Bot
Comment 7 2012-02-28 02:42:24 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.