Bug 80108

Summary: [Forms] HTMLFieldSetElement.idl doesn't have name attribute.
Product: WebKit Reporter: yosin
Component: FormsAssignee: yosin
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, morrita, ojan, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://jsfiddle.net/2yYDD/
Bug Depends on:    
Bug Blocks: 19264    
Attachments:
Description Flags
Patch 1
none
Patch 2
none
Patch 3
none
Patch 4 none

yosin
Reported 2012-03-01 23:40:50 PST
See http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#the-fieldset-element Adding "name" attribute to IDL is easy, because class HTMLFieldSetElement has disabled method inherited from HTMLFormControlElement.
Attachments
Patch 1 (3.19 KB, patch)
2012-03-02 00:15 PST, yosin 		no flags
DetailsFormatted DiffDiff
Patch 2 (4.77 KB, patch)
2012-03-02 02:00 PST, yosin 		no flags
DetailsFormatted DiffDiff
Patch 3 (4.42 KB, patch)
2012-03-04 19:17 PST, yosin 		no flags
DetailsFormatted DiffDiff
Patch 4 (4.42 KB, patch)
2012-03-05 01:28 PST, yosin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
yosin
Comment 1 2012-03-02 00:15:13 PST
Created attachment 129832 [details] Patch 1
Kent Tamura
Comment 2 2012-03-02 00:29:51 PST
Comment on attachment 129832 [details] Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=129832&action=review > Source/WebCore/html/HTMLFieldSetElement.idl:24 > + attribute DOMString name; Please the specification carefully. http://www.whatwg.org/specs/web-apps/current-work/multipage/association-of-controls-and-forms.html#dom-fe-name This IDL attribute reflects the name HTML attribute.
Kent Tamura
Comment 3 2012-03-02 00:30:26 PST
(In reply to comment #2) > Please the specification carefully. Please read the ...
Kent Tamura
Comment 4 2012-03-02 00:47:20 PST
(In reply to comment #2) > > Source/WebCore/html/HTMLFieldSetElement.idl:24 > > + attribute DOMString name; > This IDL attribute reflects the name HTML attribute. I should have added more words. Sorry for the short comment. If the specification says the attribute "reflects" a content attribute, we should add [Reflect] to the IDL. Also, we need to add tests for the "reflect" behavior. e.g. fieldset.name = null, and check getAttribute('name') value.
yosin
Comment 5 2012-03-02 02:00:07 PST
Created attachment 129849 [details] Patch 2
Hajime Morrita
Comment 6 2012-03-04 18:15:37 PST
Comment on attachment 129849 [details] Patch 2 WebKit has its own testing harness. Please consider to use it. See LayoutTests/fast/forms/ValidityState-customError.html for example.
yosin
Comment 7 2012-03-04 19:17:21 PST
Created attachment 130043 [details] Patch 3
Hajime Morrita
Comment 8 2012-03-05 01:02:23 PST
Code looks good. Could you update the patch to match ToT?
yosin
Comment 9 2012-03-05 01:28:37 PST
Created attachment 130078 [details] Patch 4
WebKit Review Bot
Comment 10 2012-03-05 19:08:10 PST
Comment on attachment 130078 [details] Patch 4 Clearing flags on attachment: 130078 Committed r109836: <http://trac.webkit.org/changeset/109836>
WebKit Review Bot
Comment 11 2012-03-05 19:08:15 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.