Bug 80122

Summary: [BlackBerry] Upstream LayerRendererSurface.{cpp, h}
Product: WebKit Reporter: Robin Cao <robin.webkit>
Component: WebKit BlackBerryAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: arvid2.nilsson, charles.wei, leo.yang, rakuco, rwlbuis, tonikitoo, webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Bug Depends on:    
Bug Blocks: 73119    
Attachments:
Description Flags
patch
none
patch-renaming none

Robin Cao
Reported 2012-03-02 00:59:25 PST
RenderSurface is the class that acts as an offscreen surface.
Attachments
patch (7.66 KB, patch)
2012-03-02 02:04 PST, Robin Cao 		no flags
DetailsFormatted DiffDiff
patch-renaming (8.74 KB, patch)
2012-03-05 04:14 PST, Robin Cao 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Robin Cao
Comment 1 2012-03-02 02:04:17 PST
Created attachment 129850 [details] patch
Nikolas Zimmermann
Comment 2 2012-03-02 02:39:05 PST
Comment on attachment 129850 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=129850&action=review > Source/WebCore/platform/graphics/blackberry/RenderSurface.h:35 > +class RenderSurface { The name of this class looks weird, it made me think we're dealing with a RenderObject derived class. Can we come up with a better name? LayerRendererSurface maybe?
Antonio Gomes
Comment 3 2012-03-04 13:07:54 PST
Comment on attachment 129850 [details] patch Agreed with Niko. Lets try renaming it...
Robin Cao
Comment 4 2012-03-05 00:31:37 PST
RenderSurface wraps an OpenGL texture which is to be rendered by hardware. As far as i can see, it's will only be used in LayerRenderer. So LayerRendererSurface looks much better to me.
Robin Cao
Comment 5 2012-03-05 04:14:39 PST
Created attachment 130092 [details] patch-renaming
Early Warning System Bot
Comment 6 2012-03-05 04:35:47 PST
Comment on attachment 130092 [details] patch-renaming Attachment 130092 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/11807751
Rob Buis
Comment 7 2012-03-05 13:28:13 PST
Comment on attachment 130092 [details] patch-renaming LGTM.
WebKit Review Bot
Comment 8 2012-03-05 15:50:27 PST
Comment on attachment 130092 [details] patch-renaming Clearing flags on attachment: 130092 Committed r109809: <http://trac.webkit.org/changeset/109809>
WebKit Review Bot
Comment 9 2012-03-05 15:50:43 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.